Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Perf Test Regression #7677

Closed
wants to merge 21 commits into from
Closed

Fix Perf Test Regression #7677

Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2632510
try reverting the chart changes to see if it impacts perf tests
cicoyle Apr 5, 2024
8659561
Merge branch 'master' into fix-perf-tests
cicoyle Apr 8, 2024
4c2a315
reset chart changes since they aren't the issue
cicoyle Apr 9, 2024
453f17f
try create reminder with fasthttp
cicoyle Apr 9, 2024
0801a83
use FastHTTPHandler
cicoyle Apr 9, 2024
19b28ae
Merge branch 'master' into fix-perf-tests
cicoyle Apr 10, 2024
25fea4b
looking at: compare/9f5a423...e08e673
cicoyle Apr 10, 2024
6ffa143
Merge branch 'master' into fix-perf-tests
cicoyle Apr 11, 2024
96b3f67
revert changes that aren't the issue
cicoyle Apr 11, 2024
d17d61a
try reverting actor/placment changes from PR: 7599 around protobuf se…
cicoyle Apr 11, 2024
00ec68b
Merge branch 'master' into fix-perf-tests
cicoyle Apr 11, 2024
60459f4
revert all changes
cicoyle Apr 12, 2024
3957199
lower targetQPS for actor_reminder test
cicoyle Apr 12, 2024
aefbb15
Update actor_reminder_test.go
cicoyle Apr 12, 2024
01aa657
lower qps again
cicoyle Apr 15, 2024
d3224b2
Merge branch 'master' into fix-perf-tests
cicoyle Apr 17, 2024
cd5987b
use fast http handler to see if that causes the diff of 5 qps
cicoyle Apr 9, 2024
55f567c
reset qps to 50
cicoyle Apr 18, 2024
f6690c0
Merge branch 'master' into fix-perf-tests
yaron2 May 3, 2024
03e41c1
Merge branch 'master' into fix-perf-tests
mukundansundar May 14, 2024
81727ba
Merge branch 'master' into fix-perf-tests
mikeee Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/perf/actor_reminder/actor_reminder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const (
appName = "perf-actor-reminder-service"

// Target for the QPS
targetQPS = 56
targetQPS = 50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowering this to acct for json being made the default, which isn't as performant as using protobufs for storage - the diff is quite noticeable with the target app CPU time. Using json requires the app to marshal and unmarshal the data increasing the target app CPU time vs using protobufs which significantly lowers the target app CPU time.

This target app CPU time diff btw protobuf & json is:
JSON: 7m CPU time
Protobuf: 1m CPU time

)

var tr *runner.TestRunner
Expand Down
Loading