Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Perf Test Regression #7677

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Fix Perf Test Regression #7677

wants to merge 20 commits into from
+208 −179

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Apr 5, 2024 •
edited

Reverting the changes from this PR updating actor code: update master w/ release-1.13 branch changes resulted in the perf tests passing again, specifically the TestActorReminderRegistrationPerformance test.
The changes involve reverting the: json serialization and api level.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 5, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 5, 2024

👋 @cicoyle, my apologies but I can't perform this action for you because your username is not in the allowlist in the file .github/scripts/dapr_bot.js.

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (091a204) to head (2632510).
Report is 5 commits behind head on master.

❗ Current head 2632510 differs from pull request most recent head 03e41c1. Consider uploading reports for the commit 03e41c1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7677      +/-   ##
==========================================
+ Coverage   61.39%   61.80%   +0.41%     
==========================================
  Files         265      245      -20     
  Lines       22609    22420     -189     
==========================================
- Hits        13880    13856      -24     
+ Misses       7579     7400     -179     
- Partials     1150     1164      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 8, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 8, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 8659561

✅ Build succeeded

  • Image tag: daprprf862568a149
  • Test image tag: daprprf862568a149

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf862568a149
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 9, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 9, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 453f17f

✅ Build succeeded

  • Image tag: daprprfeeeb9b5623
  • Test image tag: daprprfeeeb9b5623

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfeeeb9b5623
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
use FastHTTPHandler
0801a83 
Signed-off-by: Cassandra Coyle <[email protected]>
@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 9, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 9, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 0801a83

✅ Build succeeded

  • Image tag: daprprf2240022c84
  • Test image tag: daprprf2240022c84

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf2240022c84
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 10, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 10, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 25fea4b

✅ Build succeeded

  • Image tag: daprprf4379f1b29f
  • Test image tag: daprprf4379f1b29f

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf4379f1b29f
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 10, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 10, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 25fea4b

✅ Build succeeded

  • Image tag: daprprf8fcea1014e
  • Test image tag: daprprf8fcea1014e

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf8fcea1014e
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 11, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 11, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: d17d61a

✅ Build succeeded

  • Image tag: daprprf1248f82bb5
  • Test image tag: daprprf1248f82bb5

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf1248f82bb5
  • Azure region: westus3

✅ Perf tests succeeded

  • Image tag: daprprf1248f82bb5
  • Test image tag: daprprf1248f82bb5

@cicoyle cicoyle changed the title [TESTING] try reverting the chart changes to see if it impacts perf tests Fix Perf Test Regression Apr 11, 2024
@cicoyle cicoyle marked this pull request as ready for review April 11, 2024 23:19
@cicoyle cicoyle requested review from a team as code owners April 11, 2024 23:19
@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 12, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 12, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 3957199

✅ Build succeeded

  • Image tag: daprprfc623a7bd20
  • Test image tag: daprprfc623a7bd20

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfc623a7bd20
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

cicoyle
cicoyle commented Apr 12, 2024
View reviewed changes
tests/perf/actor_reminder/actor_reminder_test.go
@@ -39,7 +39,7 @@ const (
appName = "perf-actor-reminder-service"

// Target for the QPS
targetQPS = 56
targetQPS = 50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowering this to acct for json being made the default, which isn't as performant as using protobufs for storage - the diff is quite noticeable with the target app CPU time. Using json requires the app to marshal and unmarshal the data increasing the target app CPU time vs using protobufs which significantly lowers the target app CPU time.

This target app CPU time diff btw protobuf & json is:
JSON: 7m CPU time
Protobuf: 1m CPU time

@cicoyle
Update actor_reminder_test.go
aefbb15 
Signed-off-by: Cassie Coyle <[email protected]>
@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 12, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 12, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: aefbb15

✅ Build succeeded

  • Image tag: daprprfc7c31ab8e7
  • Test image tag: daprprfc7c31ab8e7

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfc7c31ab8e7
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
lower qps again
01aa657 
Signed-off-by: Cassandra Coyle <[email protected]>
@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 15, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 15, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 01aa657

✅ Build succeeded

  • Image tag: daprprf7a1f1cbc97
  • Test image tag: daprprf7a1f1cbc97

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf7a1f1cbc97
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 17, 2024

Looks like TestBulkPubsubPublishGrpcPerformance might be flaky? I will re-run the perf test since actor reminder registration one is passing now

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 17, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 17, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: d3224b2

✅ Build succeeded

  • Image tag: daprprfbef8c65e30
  • Test image tag: daprprfbef8c65e30

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprfbef8c65e30
  • Azure region: westus3

✅ Perf tests succeeded

  • Image tag: daprprfbef8c65e30
  • Test image tag: daprprfbef8c65e30

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 17, 2024

Maybe that unit test for placement membership is flaky?

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 17, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 17, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: d3224b2

✅ Build succeeded

  • Image tag: daprprf8093154c76
  • Test image tag: daprprf8093154c76

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf8093154c76
  • Azure region: westus3

✅ Perf tests succeeded

  • Image tag: daprprf8093154c76
  • Test image tag: daprprf8093154c76

@cicoyle
Copy link
Contributor Author

cicoyle commented Apr 18, 2024

/ok-to-perf

@dapr-bot
Copy link
Collaborator

dapr-bot commented Apr 18, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 55f567c

✅ Build succeeded

  • Image tag: daprprf045ce6437f
  • Test image tag: daprprf045ce6437f

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf045ce6437f
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@ItalyPaleAle
Copy link
Contributor

@cicoyle you can use /ok-to-perf actor_reminder to run just the test you're debugging, avoiding running for 3 hours which burns credit and puts out CO2 for no reason :)

@daixiang0
Copy link
Member

/ok-to-perf actor_reminder

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 13, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: f6690c0

✅ Build succeeded

  • Image tag: daprprff143206b5e
  • Test image tag: daprprff143206b5e

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprff143206b5e
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@mukundansundar
Copy link
Contributor

/ok-to-perf actor_reminder

1 similar comment
@mukundansundar
Copy link
Contributor

/ok-to-perf actor_reminder

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 14, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 03e41c1

✅ Build succeeded

  • Image tag: daprprf6e27fbe445
  • Test image tag: daprprf6e27fbe445

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf6e27fbe445
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@dapr-bot
Copy link
Collaborator

dapr-bot commented May 14, 2024 •
edited

Dapr perf test

🔗 Link to Action run

Commit ref: 03e41c1

✅ Build succeeded

  • Image tag: daprprf3c823f9ac6
  • Test image tag: daprprf3c823f9ac6

✅ Infrastructure deployed

  • Resource group name: Dapr-Perf-daprprf3c823f9ac6
  • Azure region: westus3

❌ Perf tests failed

Please check the logs for details on the error.

@cicoyle
Copy link
Contributor Author

cicoyle commented May 14, 2024

Looks like there is a panic with controller-gen that was recently introduced. This PR confirms a perf regression of ~5 for actor reminder registration - need to look into this still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cicoyle @dapr-bot @ItalyPaleAle @daixiang0 @mukundansundar @yaron2