tool_findfile: detect files in XDG home without leading dot #12135
+71
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay
force-pushed
the
fix_xdg_nodot
branch
2 times, most recently
from
87b8239
to
61d02f9
Compare
The order is now: - $XDG_CONFIG_HOME/curlrc - $XDG_CONFIG_HOME/.curlrc - $XDG_CONFIG_HOME/_curlrc (if dotscore is true) Prior to this change there was no check for the dotless version of the filename. Fixes curl#12129 Closes #xxxx
|
Any opinions on this? |
|
I haven't reviewed the code, but conceptually, this seems like the right thing to do. There's no need for a leading dot in files in ~/.config, and practically no programs do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
The order is now:
Fixes #12129
Closes #xxxx
Prior to this change there was no check for the dotless version of the filename.