Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on config file location #12952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

icp1994
Copy link

@icp1994 icp1994 commented Feb 17, 2024

curlrc -> .curlrc

@dfandrich
Copy link
Contributor

This fix looke like it matches the current behaviour, but I suspect the code is not quite right. I think it should be looking for the non-dot version of the file in the XDG_CONFIG_HOME location (which is how other programs do it), but there's explicit code in findfile.c that disables that check for some reason.

@jay
Copy link
Member

jay commented Feb 18, 2024

This fix looke like it matches the current behaviour, but I suspect the code is not quite right.

See #12129. I proposed a fix in #12135 but I've softened on it. Maybe it is better to do it this way and document the way it has been working.

@bagder
Copy link
Member

bagder commented Feb 19, 2024

I think we should fix the code rather than to document the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants