-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to AlmaLinux 10 non-minimal #242
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hostname
is not used by the bin/crate
script, where is that coming from?
In general only the documented commands (crate and crash) are supported.
If hostname
or other commands are required for some cases, we'd need test cases and docs for it, otherwise this is bound to regress again in the future.
Yes. I experimented with minimal images when transitioning from CentOS, and decided against them due to too many possible obstacles and reported about it. Even if the |
Here is the code requiring hostname https://github.com/crate/crate-operator/blob/master/crate/operator/create.py#L437-L456 |
@matriv reported this patch also fixes this issue: |
This is even worse because it additionally relies on Switching to non-minimal is okay as a quickfix, but we can't keep supporting any unknowns. Undocumented = Unsupported |
So, for the time being should we merge this and re-release the docker image, to remedy the situation? |
@mfussenegger can you spot a more viable way of getting this w/o shell expansion ? |
I am proposing to merge this, in oder to fix any downstream problems, and perform a baseline image update in a more controlled environment, accompanying a solid testing procedure 1. Footnotes
|
About
Better safe than sorry, use the non-minimal AlmaLinux image until we validated the minimal variant on all environments thoroughly.
@goat-ssh reported:
NB: Please merge at your disposal.