Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oEmbedPy and sphinxcontrib-youtube for embedding videos #568

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 24, 2025

About

Sphinx pages and Jupyter Notebooks can have video embeds, too.

Details.

  1. There was a question in the audience about whether Sphinx/MyST-NB can display videos from YouTube embedded into the Jupyter Notebook at hand.

  2. We started embedding videos on the CrateDB Guide already, but only used inline HTML up until now.

This patch intends to make it proper, by adding relevant Sphinx plugins oEmbedPy and sphinxcontrib-youtube to the stack.

Preview

References

/cc @simonprickett

@amotl amotl requested review from kneth and surister January 24, 2025 00:14
@amotl amotl marked this pull request as ready for review January 24, 2025 00:19
@amotl amotl changed the title Added oEmbedPy and sphinxcontrib-youtube for embedding videos Add oEmbedPy and sphinxcontrib-youtube for embedding videos Jan 24, 2025
Base automatically changed from myst-nb to main January 24, 2025 12:24
@amotl amotl merged commit 270e0f5 into main Jan 24, 2025
8 checks passed
@amotl amotl deleted the video branch January 24, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants