Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecAuditLogParts: add tests for the expected behavior #1304

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tty2
Copy link
Contributor

@tty2 tty2 commented Feb 10, 2025

This PR fixes the behavior for SecAuditLogParts that was not correct according to research. Look here
Additionally it separates the auditlog and errorlog logic, before it was tightly coupled and this test failed on nolog,auditlog couple together, which is not supposed according to the doc.

@tty2 tty2 requested a review from a team as a code owner February 10, 2025 09:11
@tty2 tty2 requested a review from M4tteoP February 11, 2025 17:34
@jcchavezs
Copy link
Member

@tty2 could you please enable actions in your fork?

@tty2
Copy link
Contributor Author

tty2 commented Feb 13, 2025

@jcchavezs Unfortunately actions for my account are disabled. I made a request for github support, but they answer not quick (probably during a month as I can see from threads)

@tty2
Copy link
Contributor Author

tty2 commented Feb 16, 2025

@jcchavezs I saw codecov complained about less coverage than before.
Actually I added for the cases were didn't cover before.
If go the way to make codecov happier there is only I can do is adding formal tests, that make no real profit.
WDYT? Should I add formal tests?

@jcchavezs jcchavezs changed the base branch from main to audit-log-parts-flags February 16, 2025 19:56
@jcchavezs jcchavezs changed the base branch from audit-log-parts-flags to main February 16, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants