Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log parts flags #1307

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Audit log parts flags #1307

wants to merge 6 commits into from

Conversation

jcchavezs
Copy link
Member

@jcchavezs jcchavezs commented Feb 14, 2025

Runs actions as they cannot run in #1304

@jcchavezs jcchavezs requested a review from a team as a code owner February 14, 2025 07:20
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (2b968de) to head (f1c70c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   81.77%   81.75%   -0.02%     
==========================================
  Files         170      170              
  Lines        9777     9780       +3     
==========================================
+ Hits         7995     7996       +1     
- Misses       1533     1535       +2     
  Partials      249      249              
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (-0.02%) ⬇️
coraza.rule.multiphase_valuation 81.75% <100.00%> (-0.02%) ⬇️
coraza.rule.no_regex_multiline 81.69% <100.00%> (-0.02%) ⬇️
default 81.75% <100.00%> (-0.02%) ⬇️
examples+ 16.55% <33.33%> (+<0.01%) ⬆️
examples+coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (-0.02%) ⬇️
examples+coraza.rule.multiphase_valuation 81.59% <100.00%> (-0.02%) ⬇️
examples+coraza.rule.no_regex_multiline 81.61% <100.00%> (-0.02%) ⬇️
examples+memoize_builders 81.71% <100.00%> (-0.02%) ⬇️
examples+no_fs_access 81.04% <100.00%> (-0.02%) ⬇️
ftw 81.75% <100.00%> (-0.02%) ⬇️
memoize_builders 81.85% <100.00%> (-0.02%) ⬇️
no_fs_access 81.20% <100.00%> (-0.02%) ⬇️
tinygo 81.72% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcchavezs
Copy link
Member Author

Are you happy with this @M4tteoP ?

@M4tteoP
Copy link
Member

M4tteoP commented Feb 14, 2025

Happy to see a green CI :D, allow me some time to review and reason the whole reported issue 🙇🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants