Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cawg_identity): Add BuiltInSignatureVerifier #978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Mar 18, 2025
@scouten-adobe
Copy link
Collaborator Author

This is a draft – more to do, which I'm hoping to do tomorrow morning

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.00%. Comparing base (b86eb34) to head (d747c45).

❗ There is a different number of reports uploaded between BASE (b86eb34) and HEAD (d747c45). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (b86eb34) HEAD (d747c45)
9 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #978       +/-   ##
===========================================
- Coverage   78.84%   26.00%   -52.85%     
===========================================
  Files         146      125       -21     
  Lines       35243    25723     -9520     
===========================================
- Hits        27787     6689    -21098     
- Misses       7456    19034    +11578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I found it pretty impossible to do this with a dynamic trait, but it works as an enum. If you want to merge this in, I could integrate it with my PR. I'd just like to get that PR landed if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants