feat: Adds reader.post_validate method for CAWG validation support
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accepts an implentation of the PostValidate trait It enables CAWG validation but can be used for other assertion types. validation_results.add_status no longer requires a manifest_label. manifest_assertions now use the unique assigned label rather than the base_label Ingredients have a new label field for their assigned unique label status_tracker has a new ingredient_uri method to return the ingredient_uri.
move DynamicAssertion declartions to the dynamic_assertion module.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
- Coverage 78.84% 78.55% -0.30%
==========================================
Files 146 147 +1
Lines 35243 35569 +326
==========================================
+ Hits 27787 27940 +153
- Misses 7456 7629 +173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scouten-adobe
changed the title
scouten-adobe
changed the title
reader.post_validate method for CAWG validation support
scouten-adobe
requested changes
Mar 17, 2025
…th/c2pa-rs into gpeacock/post_validate
…th/c2pa-rs into gpeacock/post_validate
StatusTracker can keep track of the current_uri for logging. Added log_current_item c2pa_tool supports CAWG validation
scouten-adobe
approved these changes
Mar 18, 2025
cawg_identity/src/tests/identity_assertion/validation_method/continue_when_possible.rs
Show resolved
Hide resolved
cawg_identity/src/tests/identity_assertion/validation_method/continue_when_possible.rs
Show resolved
Hide resolved
cawg_identity/src/tests/identity_assertion/validation_method/continue_when_possible.rs
Outdated
Show resolved
Hide resolved
cawg_identity/src/tests/identity_assertion/validation_method/continue_when_possible.rs
Outdated
Show resolved
Hide resolved
cawg_identity/src/tests/identity_assertion/validation_method/stop_on_error.rs
Show resolved
Hide resolved
PostValidatorAsync renamed to AsyncPostValidator for consistency Uses correct cawg success code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adds Reader PostValidate method + PostValidator trait.
feat: Rename PreliminaryClaim to PartialClaim
feat: put RemoteSigner behind v1_api
feat: adds builder.sign_file_async()
feat: Adds reader.post_validate_async _ AsyncPostValidator trait.
chore: Adds cawg.rs example for cawg sign and validate.
feat: adds cawg validate to c2patool
feat: adds CawgValidator for post validating cawg content.