-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Re-enable PROPACK tests #200
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
70d619b
to
f9913be
Compare
As expected, this essentially reproduces the state from 1.8.0rc3:
** sum of Segfaults (S), Failures (F), resp. Timeouts (T); out of a total of 54 CI combinations being tested |
This is on my radar, just swamped recently and will pick this back as soon as I can |
No worries, there's no rush. I just wanted to open the PR for support and as a reminder for us all. |
@mckib2 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
So relative to #224, this has no increase of test failures, and certainly all the propack segfaults on windows are gone 🤩 🥳 |
Broken aarch/ppc builds have nothing to do with propack, investigating in #232 |
e43c451
to
c4b34da
Compare
…nda-forge-pinning 2023.05.05.18.28.01
OK, taking the last results of #224 as a baseline (minus scipy/scipy#18371, which got fixed in #233) and then switching on propack again, the results are as follows
Notable:
In more detail:
osx + mkl: 13-15 failures out of 42, at randomUnion of all 42 failures (CPython & PyPy)
Union of CPython failures (33)
Union on fall PyPy failures (21)
Per Python VersionCPython 3.11
CPython 3.10
CPython 3.9
CPython 3.8
PyPy 3.9 (not displaying known failures of
PyPy 3.8 (not displaying known failures of
win: 10-31 failures out of 43, at randomThe numbers below are for blis, but the runs for the other implementations look the same (though the random sample of tests per run is obviously different). Union of all 43 failures (CPython & PyPy)
Union of CPython failures (36)
Union of CPython failures (28)
Per Python VersionCPython 3.11
CPython 3.10
CPython 3.9
CPython 3.8
PyPy 3.9
PyPy 3.8
|
I probably know what the root cause is. It's related to the ABI wrappers, so it makes sense that it only shows up with MKL. Basically, the use of |
with PROPACK enabled however
This has been fixed/re-enabled by scipy/scipy#19855, so closing this. |
The PROPACK tests were disabled in scipy/scipy#15479 to unblock the release of 1.8.0. Still, we should fix this, so opening this PR to try to help iterate. Happy to play with any upstream commits / PRs (including submodules) here.
CC @mckib2