ENH: Re-enable PROPACK by default #18354
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a long story with PROPACK. There were a bunch of segfaults in the first scipy version that contained it, and ultimately it got disabled by default, because we weren't able to figure out the origin of the windows segfaults (main issue, though there were others...).
Now it seems though that the CI gods have shown some kindness and decided to let the PROPACK tests pass as of 1.10.x.
I discovered this after 1.10 was released, so the decision was to re-enable this for 1.11.
Fixes #15108