Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Re-enable PROPACK by default #18354

Closed
wants to merge 1 commit into from
Closed

Conversation

h-vetinari
Copy link
Member

It's been a long story with PROPACK. There were a bunch of segfaults in the first scipy version that contained it, and ultimately it got disabled by default, because we weren't able to figure out the origin of the windows segfaults (main issue, though there were others...).

Now it seems though that the CI gods have shown some kindness and decided to let the PROPACK tests pass as of 1.10.x.

I discovered this after 1.10 was released, so the decision was to re-enable this for 1.11.

Fixes #15108

@rgommers
Copy link
Member

It's still pretty thoroughly broken unfortunately with MKL and Accelerate, the ABI wrappers and build setup are buggy and require an overhaul. I fixed a couple of minor things last week, but there's quite a bit more to do. It's going to be a lot more prominent when macOS is going to default to Accelerate again. So I'd be inclined to leave this alone for 1.11.0.

@h-vetinari
Copy link
Member Author

We could try enabling PROPACK by default for 1.11 in conda-forge, that way we can gauge the impact a bit, and if things go bad, it's easier to mark something as broken in conda-forge than on PyPI.

@rgommers
Copy link
Member

That seems like a good approach.

@rgommers rgommers marked this pull request as draft May 10, 2023 10:19
@rgommers
Copy link
Member

Converted to draft, will post on gh-15108 what is left to do before this can be merged.

@lucascolley lucascolley added this to the 1.13.0 milestone Dec 4, 2023
@lucascolley
Copy link
Member

will post on #15108 what is left to do before this can be merged

That comment is #15108 (comment)

@rgommers
Copy link
Member

Continued in gh-19855, so closing this PR. Thanks @h-vetinari

@rgommers rgommers closed this Feb 27, 2024
@h-vetinari h-vetinari deleted the propack branch February 27, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.sparse.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Seg. fault in scipy.sparse.linalg tests in PROPACK
3 participants