Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline redefinition in Visual Studio when compiling C++ code #46

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 10, 2020

Fix #45 by back-porting ruby/ruby@49bb2e6 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@wolfv wolfv added the automerge Merge the PR when CI passes label Nov 10, 2020
@wolfv
Copy link
Member

wolfv commented Nov 10, 2020

thx. looks good!

@github-actions github-actions bot merged commit e42c5e5 into conda-forge:master Nov 10, 2020
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSVC: C++ code that includes ruby/config.h fails with inline redefinition error
3 participants