Rebuild for libboost 1.84 #37
Conversation
…nda-forge-pinning 2024.05.15.19.07.12
regro-cf-autotick-bot
requested review from
seanyen,
traversaro and
wolfv
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
osx running into I'm wondering if this is related to the libcxx ABI issues we've been seeing. |
Interesting, do you have any reference? |
|
…nda-forge-pinning 2024.05.29.16.17.59
|
Hm, libcxx issues look to be unrelated. |
Thanks for checking that out! |
|
The vcpkg version of ompl is working fine with boost 1.84 and boost 1.85 on mac os both x64 and amd64. There are a few patches that might be helpful. |
|
There were some problems with libcxx hardening mode being enabled in release builds (see conda-forge/libcxx-feedstock#162), they have been fixed, so let's try to re-render. |
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.07.31.04.56.44
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin please rerender |
|
fyi @h-vetinari I removed the |
…nda-forge-pinning 2024.07.31.04.56.44
If that is the problem, it may be nevertheless useful to report the test failures upstream. |
Yes, absolutely! We shouldn't ever publish builds based on
AFAIR the problems here precede the publication of libcxx 18, so they are unlikely to be related. But it may be worth checking out the vcpkg patches and see if we can pick up something missing. |
I quickly checked them and they seem all to be related to CMake packaging, so I am not sure if they are related. Note that anyhow vcpkg does not run the projects' test suite as part of their CI, so (unless someone run those test somewhere else) we are not sure if they do not have those failures as well. |
|
Indeed, this is still failing: Let's open a debug PR to understand if this is actually related to boost 1.84 . |
Actually we have the answer, #38 that builds with boost 1.83 the tests are passing fine. |
|
Ah right, I recall now that this was failing the tests somehow; Given the following warning in the implementation it could be perhaps that there's some UB going on that happens to pass on linux/win, but not on newer clang anymore? |
This PR has been triggered in an effort to update boost1840.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9103630188 - please use this URL for debugging.