Use -framework for libunwind; disable hardening
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to be done through `-framework`, attempting to do add `-L/usr/lib/system -lunwind` to LDFLAGS leads to: "Link against the umbrella framework 'System.framework' instead"
This has been part of regular libc++.dylib since LLVM 9, see llvm/llvm-project@cc37af7 & llvm/llvm-project@9523872
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hardening modes have been untroduced in libc++ 18. It might be that checks for some UB are now present but were not before. See: https://libcxx.llvm.org/Hardening.html#using-hardening-modes Signed-off-by: Julien Jerphanion <[email protected]>
h-vetinari
changed the title
-framework for libunwind-framework for libunwind; disable hardening
h-vetinari
requested review from
SylvainCorlay,
beckermr,
inducer,
isuruf,
jakirkham and
timsnyder
as code owners
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #172 (we're slowly inching closer to the pre-18 state of things again) & #174
Fixes #162