Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with libcxx 18 #136

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Build with libcxx 18 #136

merged 1 commit into from
Aug 9, 2024

Conversation

jdblischak
Copy link
Collaborator

The issue with libcxx 18 from conda-forge has been resolved. They had enabled a new hardening mode in libcxx 18 that searches for undefined behavior (conda-forge/libcxx-feedstock#162 (comment)). Disabling this hardening removes the Illegal instruction error (conda-forge/libcxx-feedstock#173, conda-forge/libcxx-feedstock#174).

xref: #125, #131

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️ Thank you

@jdblischak jdblischak merged commit 9c88165 into TileDB-Inc:master Aug 9, 2024
3 of 5 checks passed
@jdblischak jdblischak deleted the libcxx-18 branch August 9, 2024 15:44
@jdblischak
Copy link
Collaborator Author

jdblischak commented Aug 19, 2024

No new binaries were uploaded in the merged commit, 9c88165, because the uploads all failed. This is presumably due to the fact that we recently ran out of storage space on anaconda.org. I deleted some stale nightlies to give us a little extra space, but it will fill up again soon enough.

Given that we don't currently have any solver errors related to libcxx, and that the tiledbvcf-py binaries are bloated due to unnecessary bundling of all its linked shared objects (TileDB-Inc/TileDB-VCF#717), I am not going to bother restarting the builds to upload new binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants