Add --team flag to rename-pipeline command

[Priyanshinv]

Changes proposed by this PR

Allow users to rename pipeline for a non-default team

closes one of the items in #5215

• add team flag to rename-pipeline
• integration tests
• update documentation

Notes to reviewer

In rename_pipeline_test.go, it might look like there are a lot of changes made, but there are only 2 major changes:

1. Created a new context "when team is not specified" and added all the existing test cases to this one
2. Created a new context "when a non-default team is specified" and added a new test case to this one

Tested the changes by running "ginkgo -r -p" on the path: "concourse/fly/integration"

Release Note

• Added team flag to fly command rename-pipeline. Usage: fly -t dev rename-pipeline -o some-pipeline -n new-pipeline --team other-team

[taylorsilva]

Thanks for the PR! Will check it out over the next few days when I have time.

[taylorsilva]

Error from integration looks unrelated:

==== EXEC docker-compose up -d --build

Recreating testpipelinepauser_db_1 ... 

[22841] Failed to execute script docker-compose


ERROR: for testpipelinepauser_db_1  'ContainerConfig'


ERROR: for db  'ContainerConfig'

Traceback (most recent call last):

  File "bin/docker-compose", line 3, in <module>

  File "compose/cli/main.py", line 67, in main

  File "compose/cli/main.py", line 126, in perform_command

  File "compose/cli/main.py", line 1070, in up

  File "compose/cli/main.py", line 1066, in up

  File "compose/project.py", line 648, in up

  File "compose/parallel.py", line 108, in parallel_execute

  File "compose/parallel.py", line 206, in producer

  File "compose/project.py", line 634, in do

  File "compose/service.py", line 579, in execute_convergence_plan

  File "compose/service.py", line 501, in _execute_convergence_recreate

  File "compose/parallel.py", line 108, in parallel_execute

  File "compose/parallel.py", line 206, in producer

  File "compose/service.py", line 494, in recreate

  File "compose/service.py", line 613, in recreate_container

  File "compose/service.py", line 332, in create_container

  File "compose/service.py", line 917, in _get_container_create_options

  File "compose/service.py", line 957, in _build_container_volume_options

  File "compose/service.py", line 1532, in merge_volume_bindings

  File "compose/service.py", line 1562, in get_container_data_volumes

KeyError: 'ContainerConfig'

==== exit status 255

==== EXEC docker-compose logs --no-color

==== EXEC docker-compose kill

Killing testpipelinepauser_worker_1 ... done

Killing testpipelinepauser_web_1    ... done

==== EXEC docker-compose down -v

Removing testpipelinepauser_worker_1          ... done

Removing testpipelinepauser_web_1             ... done

Removing f45774b3955b_testpipelinepauser_db_1 ... done

Removing network testpipelinepauser_default

Removing volume testpipelinepauser_postgresData

--- FAIL: TestPipelinePauser (177.73s)

    cmd.go:84: ExitCode 255 != 0

FAIL

FAIL	github.com/concourse/concourse/integration/pauser	177.772s

ok  	github.com/concourse/concourse/integration/worker	240.754s

FAIL

EDIT: yup, getting the same error in the main dev pipeline too. Need to fix that first before we can merge any PR's in.

[taylorsilva]

@Priyanshinv The integration tests have been fixed. If you can rebase your PR branch on master then everything should pass and we can merge your PR in

[Priyanshinv]

@taylorsilva I've rebased the PR branch and all checks have now passed. If all looks good, please merge my PR.