Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --team to remaining fly commands #5215

Open
19 of 24 tasks
taylorsilva opened this issue Feb 21, 2020 · 31 comments
Open
19 of 24 tasks

Add --team to remaining fly commands #5215

taylorsilva opened this issue Feb 21, 2020 · 31 comments
Labels
good first issue release/undocumented This didn't warrant being documented or put in release notes.

Comments

@taylorsilva
Copy link
Member

taylorsilva commented Feb 21, 2020

Goal

Implement --team for remaining fly commands. fly/integration tests should be updated. Cases should be added to the error_handling file as well

Context("when --team is set", func() {

# use default team
fly -t ci <command> <command-options>
# use another team
fly -t ci <command> <command-options> --team other-team
  • checklist
  • execute
  • pause-pipeline
  • rename-pipeline
  • watch
  • abort-build
  • archive-pipeline
  • check-resource
  • check-resource-type
  • clear-task-cache
  • destroy-pipeline
  • expose-pipeline
  • get-pipeline
  • hide-pipeline
  • order-pipelines
  • resource-versions
  • resources
  • set-pipeline
  • unpause-pipeline
  • hijack
  • jobs
  • pause-job
  • trigger-job
  • unpause-job

Background

Follow-up story from #4196. You can look at trigger-job for guidance on how to implement the flag.
You can look at #7492 on how to implement the flag for the remaining commands.

@vito vito added this to To do in Roadmap via automation May 8, 2020
@vito vito moved this from To do to Icebox in Roadmap May 8, 2020
ozzywalsh added a commit to ozzywalsh/concourse that referenced this issue May 17, 2020
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines
from teams other than the current target. See concourse#5215.

Fix formatting

Remove FDescribe from test

Add error handling test for unpause-pipeline --team
ozzywalsh added a commit to ozzywalsh/concourse that referenced this issue May 17, 2020
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines
from teams other than the current target. See concourse#5215.

Signed-off-by: Ozzy Walsh <[email protected]>
ozzywalsh added a commit to ozzywalsh/concourse that referenced this issue May 17, 2020
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines
from teams other than the current target. See concourse#5215.

Signed-off-by: Ozzy Walsh <[email protected]>
ozzywalsh added a commit to ozzywalsh/concourse that referenced this issue May 17, 2020
Adds a `--team` flag to `unpause-pipeline` to allow unpausing pipelines
from teams other than the current target. See concourse#5215.

Signed-off-by: Ozzy Walsh <[email protected]>
@muang0
Copy link
Contributor

muang0 commented Jun 22, 2020

Hi @taylorsilva hope you had a good weekend! I would like to take one of these as a first contribution to concourse 😄 Picking one at random, I'll start on set-pipeline assuming its available?

@taylorsilva
Copy link
Member Author

@jroden set-pipeline is available to work on! Looking forward to your contribution :)

@xtreme-sameer-vohra xtreme-sameer-vohra added the release/undocumented This didn't warrant being documented or put in release notes. label Jul 10, 2020
@khng
Copy link
Contributor

khng commented Jul 27, 2020

Hi @taylorsilva!

Was hoping to pick up the destroy-pipeline command for this issue.

Let me know if there are any issues!

@taylorsilva
Copy link
Member Author

All yours! Thanks for contributing :)

owenfarrell added a commit to owenfarrell/concourse that referenced this issue Jul 28, 2020
owenfarrell added a commit to owenfarrell/concourse that referenced this issue Jul 28, 2020
owenfarrell added a commit to owenfarrell/concourse that referenced this issue Jul 28, 2020
owenfarrell added a commit to owenfarrell/concourse that referenced this issue Jul 28, 2020
khng pushed a commit to khng/concourse that referenced this issue Jul 30, 2020
Allow for users to destroying pipelines for different teams
without switching targets

concourse#5215

Signed-off-by: Ka Hin Ng <[email protected]>
khng pushed a commit to khng/concourse that referenced this issue Jul 30, 2020
Allow for users to destroying pipelines for different teams
without switching targets

concourse#5215

Signed-off-by: Ka Hin Ng <[email protected]>
khng pushed a commit to khng/concourse that referenced this issue Jul 30, 2020
Allow for users to destroying pipelines for different teams
without switching targets

concourse#5215

Signed-off-by: Ka Hin Ng <[email protected]>
khng pushed a commit to khng/concourse that referenced this issue Jul 30, 2020
Allow for users to destroying pipelines for different teams
without switching targets

concourse#5215

Signed-off-by: Ka Hin Ng <[email protected]>
@techgaun
Copy link
Member

techgaun commented Oct 5, 2020

@taylorsilva is the get-pipeline available to pick? I would like to take that if its free. Same goes for expose-pipeline but would like to tackle get-pipeline first.

@taylorsilva
Copy link
Member Author

@techgaun they're both yours! Thanks for the help :)

techgaun added a commit to techgaun/concourse that referenced this issue Oct 9, 2020
Allows fly cli to get pipeline for different teams
without having to switch targets

concourse#5215

Signed-off-by: techgaun <[email protected]>
techgaun added a commit to techgaun/concourse that referenced this issue Oct 10, 2020
Allows fly cli to get pipeline for different teams
without having to switch targets

concourse#5215

Signed-off-by: techgaun <[email protected]>
techgaun added a commit to techgaun/concourse that referenced this issue Oct 25, 2020
Allows fly cli to expose pipeline for different
team without having to switch targets

concourse#5215

Signed-off-by: techgaun <[email protected]>
aoldershaw pushed a commit that referenced this issue Oct 27, 2020
Allows fly cli to expose pipeline for different
team without having to switch targets

#5215

Signed-off-by: techgaun <[email protected]>
@techgaun
Copy link
Member

techgaun commented Oct 28, 2020

@taylorsilva looks like #5917 added team arg for hide-pipeline already. I would like to take the rename-pipeline instead since that seems to be available.

@taylorsilva
Copy link
Member Author

Thanks for pointing that out! Updated the comment. Thanks again for your help!

evanchaoli pushed a commit to evanchaoli/concourse that referenced this issue Jan 25, 2021
… to 6.7.x

Allows fly cli to get pipeline for different teams
without having to switch targets

concourse#5215

Signed-off-by: techgaun <[email protected]>

Conflicts:
	fly/commands/get_pipeline.go
@tech-geek29
Copy link
Member

@taylorsilva is the destroy-pipeline available to pick? I would like to pick that if its free!

@taylorsilva
Copy link
Member Author

@tech-geek29 all yours, thank you!

@tech-geek29
Copy link
Member

@taylorsilva I think destroy-pipeline is already done & merged! I think it should be checked in above Goal.

I can pick up checklist. I see that is free!

@taylorsilva
Copy link
Member Author

It is, wonder when that got it 🤔 Feel free to do any of them and tag this issue in the PR

@tech-geek29
Copy link
Member

@taylorsilva I do not have contributor access role. I am not able to add label to PR. What is the process for that?

@aoldershaw
Copy link
Contributor

aoldershaw commented Jun 14, 2021

@tech-geek29 I just approved your request to join contributors in https://github.com/concourse/governance (welcome!) - can you try to add the label again?

EDIT: you may have to approve an invitation, let us know if you didn't receive one

@tech-geek29
Copy link
Member

Thanks very much @aoldershaw , I was able to attach labels. @taylorsilva @aoldershaw I have raised PR #7162. Can you please review and approve it?

@taylorsilva
Copy link
Member Author

taylorsilva commented Jun 14, 2021

It'll be assigned to someone tomorrow during standup for review. Thanks for the PR!

@tech-geek29
Copy link
Member

Awesome! Thanks @taylorsilva

@dhantha
Copy link

dhantha commented Aug 3, 2021

Hi @taylorsilva I would like to work on fly watch

@taylorsilva
Copy link
Member Author

@dhantha sorry for the late reply, but go for it!

@Caprowni
Copy link
Contributor

Caprowni commented Nov 5, 2021

@taylorsilva are some of these still up for grabs? (The ones that are unticked) Will take a look at getting to a couple of them :)

@taylorsilva
Copy link
Member Author

@Caprowni the list is up to date, tackle any that you like :)

@taylorsilva
Copy link
Member Author

List is still up to date

@Caprowni
Copy link
Contributor

Caprowni commented Apr 5, 2024

Hey 👋 @taylorsilva I think there are a few that need ticked off the list that have already been done:

check-resource
check-resource-type
resources
resource-versions
archive-pipeline

@taylorsilva
Copy link
Member Author

List is now definitely up to date. Thanks @Caprowni!

Sorted the list too so unfinished items are at the top.

@Priyanshinv
Copy link
Contributor

Hi @taylorsilva , have raised a PR #8940 for adding --team flag to rename-pipeline command. Could you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue release/undocumented This didn't warrant being documented or put in release notes.
Projects
Roadmap
  
Icebox
Development

No branches or pull requests