Add --team flag to fly destroy-pipeline command
#5924
Conversation
khng
force-pushed
the
destroy-pipeline-team-command
branch
2 times, most recently
from
bb3d8de
to
781b9ea
Compare
khng
changed the title
There was a problem hiding this comment.
Thanks for the contribution! Looks great, and works exactly as I'd expect.
One small thing - could you remove your release note from release-notes/latest.md? There's currently a merge conflict. I would normally suggest just rebasing onto master, but we're actually changing our release note process to have the release notes auto generated by the PRs that were merged into master - so, having a release note in release-notes/latest.md actually has no effect!
By default, the release note is just the PR title (along with your GitHub username). If you want to add more context to your PR in the release note, you could add a ## Release Note header to your PR description and put whatever markdown under there - but I think your PR title is pretty descriptive already!
Allow for users to destroying pipelines for different teams without switching targets concourse#5215 Signed-off-by: Ka Hin Ng <[email protected]>
khng
force-pushed
the
destroy-pipeline-team-command
branch
from
781b9ea
to
ecd4b78
Compare
|
Thanks for taking a look! I have removed the release note change. I'll make note of that for future PRs! :) |
|
On a side note, should I be able to view the details of the checks? |
|
@khng thanks!
We have a PR bot that should invite anyone who opens a PR to the concourse/contributors team (which has access to the checks), though I think it's been misbehaving as of late. I'll invite you manually for now. Looks like the test just timed out (been seeing that a bit more recently, should probably look into that...) - I retriggered it, hopefully it'll pass this time around! Doesn't seem related to your change |
aoldershaw
changed the title
--team option to fly destroy-pipeline command
aoldershaw
changed the title
--team option to fly destroy-pipeline command--team flag to fly destroy-pipeline command
aoldershaw
added
the
release/undocumented
Allow for users to destroying pipelines for different teams
without switching targets
#5215
Signed-off-by: Ka Hin Ng [email protected]
What does this PR accomplish?
Feature
Changes proposed by this PR:
--teamflag forfly destroy-pipelinecommand.Notes to reviewer:
Contributor Checklist
Reviewer Checklist
BOSH and
Helm packaging; otherwise, ignored for
the integration
tests
(for example, if they are Garden configs that are not displayed in the
--helptext).