Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentdf-client: migrate to Conan v2 #18832

Merged
merged 7 commits into from
Aug 22, 2023
Merged

opentdf-client: migrate to Conan v2 #18832

merged 7 commits into from
Aug 22, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023 •
edited by jcar87
Loading

  • Update recipe to support Conan 2.0

Other fixes:

  • Add missing direct dependency on ZLIB
  • Move patched logic to call find_package to a separate project include file
  • Add missing component requirement in package_info() for magic_enum
  • Support the shared option, and add package_type attribute
    • Add the shared option
    • Throw an exception in the validate() method when shared=True on Windows (not supported)
    • Patch the CMake scripts to not install both static and shared variants into the package folder - only install one of them
    • Correctly set the library name in package_info() depending on the shared option value
  • Other CMake fixes:
    • Comment out logic to build a "combined" static library with all static library dependencies in the same archive - this is not intended to be supported in Conan Center, and this file was not being used (as it was not advertised in package_info()

@ghost
Copy link

ghost commented Jul 22, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying opentdf-client/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jul 22, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 24, 2023
Closed
Merged
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 17, 2023
@jcar87 jcar87 self-assigned this Aug 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87 jcar87 force-pushed the migrate/opentdf-client branch from 5295904 to 0bf4881 Compare August 21, 2023 10:33
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Aug 21, 2023

Thanks, @jcar87!

@valgur valgur marked this pull request as ready for review August 21, 2023 16:58
@prince-chrismc prince-chrismc mentioned this pull request Aug 21, 2023
Open
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (36091ba3e4919442d3c22896e2fa60fe6eda0c9d):

  • opentdf-client/1.3.10:
    All packages built successfully! (All logs)

  • opentdf-client/1.4.0:
    All packages built successfully! (All logs)

  • opentdf-client/1.5.0:
    All packages built successfully! (All logs)

  • opentdf-client/1.1.6:
    All packages built successfully! (All logs)

  • opentdf-client/1.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 11 (36091ba3e4919442d3c22896e2fa60fe6eda0c9d):

  • opentdf-client/1.1.6:
    All packages built successfully! (All logs)

  • opentdf-client/1.5.0:
    All packages built successfully! (All logs)

  • opentdf-client/1.4.0:
    All packages built successfully! (All logs)

  • opentdf-client/1.3.10:
    All packages built successfully! (All logs)

  • opentdf-client/1.2.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 370c774 into conan-io:master Aug 22, 2023
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@valgur @jcar87 @ericLemanissier
(conan-io#18832) opentdf-client: migrate to Conan v2
bf81b92 
* opentdf-client: migrate to Conan v2

* opentdf-client: restore VirtualRunEnv in test_package

* opentdf-client: resolve conflicts and remove old versions

* opentdf-client fix config.yml

* opentdf fixes for Conan 2.0

* opentdf client: remove test_v1_package

* opentdf-client: fix patches for install location

---------

Co-authored-by: Luis Caro Campos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcar87 jcar87 jcar87 approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @jcar87 @AbrilRBS