Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for opentdf-client 1.4.0 #17916

Closed
wants to merge 3 commits into from
Closed

Version bump for opentdf-client 1.4.0 #17916

wants to merge 3 commits into from

Conversation

patmantru
Copy link
Contributor

@patmantru patmantru commented Jun 12, 2023

Specify library name and version: opentdf-client/1.4.0

Adds support for IC-TDF format


@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 6ea5d4c
opentdf-client/1.1.3
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.10
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.1.5
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.9
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.6
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.8
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.4
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.2.0
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.1.2
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.3
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.3.2
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.1.6
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib
opentdf-client/1.4.0
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libopentdf.dylib

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! I only have one minor comment about the new magic-enum dependency

@@ -70,6 +70,7 @@ def requirements(self):
self.requires("ms-gsl/2.1.0")
self.requires("nlohmann_json/3.11.1")
self.requires("jwt-cpp/0.4.0")
self.requires("magic_enum/0.8.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this requirement always been necessary? Or is it just from 1.4.0 onwards? If so, a version check to conditionally add it would be better :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 5, 2023

Hi @patmantru, could you please sign the CLA so that this recipe can get merged? Thanks!

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jul 24, 2023

I detected other pull requests that are modifying opentdf-client/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!


Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!

@ghost ghost mentioned this pull request Jul 25, 2023
3 tasks
@patmantru patmantru closed this Jul 25, 2023
@patmantru patmantru deleted the opentdf-client-version-1.4.0 branch November 1, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants