-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump for opentdf-client 1.4.0 #17916
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6ea5d4copentdf-client/1.1.3
opentdf-client/1.3.10
opentdf-client/1.1.5
opentdf-client/1.3.9
opentdf-client/1.3.6
opentdf-client/1.3.8
opentdf-client/1.3.4
opentdf-client/1.2.0
opentdf-client/1.1.2
opentdf-client/1.3.3
opentdf-client/1.3.2
opentdf-client/1.1.6
opentdf-client/1.4.0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I only have one minor comment about the new magic-enum dependency
@@ -70,6 +70,7 @@ def requirements(self): | |||
self.requires("ms-gsl/2.1.0") | |||
self.requires("nlohmann_json/3.11.1") | |||
self.requires("jwt-cpp/0.4.0") | |||
self.requires("magic_enum/0.8.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this requirement always been necessary? Or is it just from 1.4.0 onwards? If so, a version check to conditionally add it would be better :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @patmantru, could you please sign the CLA so that this recipe can get merged? Thanks! |
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying opentdf-client/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ❌Sorry, the system is under maintenance and it doesn't accept builds right now. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the system is under maintenance and it doesn't accept builds right now. |
Specify library name and version: opentdf-client/1.4.0
Adds support for IC-TDF format