Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for new Types supported for Drupal. #285

Closed
wants to merge 3 commits into from

Conversation

miteshmap
Copy link

No description provided.

@jadb
Copy link
Member

jadb commented Mar 23, 2016

There are a couple Drupal related updates (i.e. #294 #273 #264 #65). Since am very unfamiliar with Drupal, if everyone who submitted could vouch for one PR and/or rebase the necessary ones, will make it that much easier to merge.

@edysmp
Copy link

edysmp commented Mar 23, 2016

All are for different reasons. #273 isn't that common, but possible and is a new theme engine. #294 desires to default all of these "things" into a contrib folder. #264 wants to add a new project classification (I'm not sure it is necessary). And #179 wants to add a sites folder.

In reality, we should continue the standard of a "contrib" folder (per #294) in each of these new types and also have a "custom" option too. An exception is for #179, where having a contrib vs custom doesn't make sense for sites.

@edysmp
Copy link

edysmp commented Mar 23, 2016

PR #294 updated for all.

@ofry
Copy link

ofry commented Apr 15, 2019

This PR has merge conflicts.

@Seldaek Seldaek closed this Dec 8, 2020
@Seldaek Seldaek deleted the branch composer:main December 8, 2020 13:43
@Seldaek Seldaek reopened this Dec 8, 2020
@Seldaek Seldaek changed the base branch from master to main December 8, 2020 13:48
@Seldaek
Copy link
Member

Seldaek commented Dec 8, 2020

Going to close this as I assume this is not needed anymore. If it is then it should be discussed in concert with the drupal team, as at this point so many Drupal sites are out there depending on the behavior here that I am not really comfortable changing the behavior without consulting people who are more in the know.

@Seldaek Seldaek closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants