Update DrupalInstaller.php #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, this (a "project" type) would be an awesome addition for working with https://github.com/drupal-composer/drupal-project as a dependency.
janstoeckler
added a commit
to janstoeckler/drupal-project
that referenced
this pull request
Oct 7, 2015
This would be a welcome change if or once composer/installers#264 is accepted, for using drupal-composer/drupal-project itself as a dependency.
|
Please see: #285 (comment) |
|
This PR has merge conflicts. |
|
Going to close this as I assume this is not needed anymore. If it is then it should be discussed in concert with the drupal team, as at this point so many Drupal sites are out there depending on the behavior here that I am not really comfortable changing the behavior without consulting people who are more in the know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this (a "project" type) would be an awesome addition for working with https://github.com/drupal-composer/drupal-project as a dependency.