-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cryptography] Introudce Array
#447
[cryptography] Introudce Array
#447
Conversation
When running the
Not sure how we want to handle the first error. |
Octets
Just need to fix the signing tests now! |
utils/src/lib.rs
Outdated
@@ -97,6 +97,26 @@ pub fn modulo(bytes: &[u8], n: u64) -> u64 { | |||
result | |||
} | |||
|
|||
pub trait Serializable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't implement this as part of the Octets
trait, we can implement it for other types (like u64
)
Octets
FormattedArray
FormattedArray
Array
@@ -25,15 +19,13 @@ fn benchmark_signature_verification(c: &mut Criterion) { | |||
|| { | |||
let mut signer = Bls12381::new(&mut thread_rng()); | |||
let signature = signer.sign(Some(namespace), &msg); | |||
let public = group::Public::deserialize(signer.public_key().as_ref()).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would've seen a nice benchmark gain if this was previously using Scheme (as it should've been).
Closes: #411
Unify representation of fixed-length bytes and detect malformed bytes on parse.
Future Work: #457