Skip to content

[codec] Replace Protobuf with Manual Packing #489

Closed
@patrick-ogrady

Description

@patrick-ogrady

When first implementing the p2p primitive, I decided to use Protobuf and represent PublicKey/Signature with Bytes (which prost could automatically use). However, the migration to Array (#447) makes Protobuf a lot less enjoyable to use (it was already less performant but is also even more so now).

We now need to parse fields from proto and keep them around with the proto object:

We should consider dropping protobuf altogether in primitives for manually packed byte payloads (which can parse generic types directly).

Related: #454

Metadata

Metadata

Assignees

Labels

audit blockerClosing these issues is a blocking requirement to kicking off an audit of the Commonware Library.researchMore work required

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions