Closed
Description
When first implementing the p2p
primitive, I decided to use Protobuf
and represent PublicKey/Signature with Bytes
(which prost
could automatically use). However, the migration to Array
(#447) makes Protobuf
a lot less enjoyable to use (it was already less performant but is also even more so now).
We now need to parse fields from proto and keep them around with the proto object:
Lines 30 to 38 in ccf2f88
- https://github.com/commonwarexyz/monorepo/blob/b668dfad229fd16797c29f4fb461544f1b4fa72e/broadcast/src/linked/safe/private.rs
We should consider dropping protobuf altogether in primitives for manually packed byte payloads (which can parse generic types directly).
Related: #454
Metadata
Metadata
Assignees
Labels
Type
Projects
Status