Skip to content

CarHarness: generate parts list #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

incognitojam
Copy link
Collaborator

@incognitojam incognitojam commented Mar 26, 2025

@incognitojam incognitojam added the enhancement new feature or request label Mar 26, 2025
Copy link
Contributor

github-actions bot commented Mar 26, 2025

deployed preview: https://comma-web--pr58-7jmgbgsn.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

@incognitojam incognitojam force-pushed the harness-parts-2 branch 2 times, most recently from c06fb44 to fdb79ad Compare March 26, 2025 02:04
@incognitojam incognitojam changed the title CarHarness: generate non-standard harness list CarHarness: generate parts list Mar 26, 2025
@incognitojam incognitojam marked this pull request as ready for review March 26, 2025 02:09
@incognitojam incognitojam marked this pull request as draft March 26, 2025 02:15
@incognitojam incognitojam marked this pull request as ready for review March 26, 2025 02:18
@incognitojam incognitojam requested a review from sshane March 26, 2025 02:22
@incognitojam incognitojam marked this pull request as draft March 26, 2025 12:01
@incognitojam incognitojam marked this pull request as ready for review March 26, 2025 12:38
Comment on lines +33 to +34
if product_name == "OBD-II":
parts |= {"OBD-II connector"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserves what was shown previously

@sshane
Copy link
Contributor

sshane commented Mar 27, 2025

We need to put the angled mounts somewhere, fulfillment uses them. Adeeb wanted to make a dropdown by car. For now let's not delete the harness parts page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants