Naming: rename setup and cleanup tasks #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
requested review from
denverwilliams,
agentpoyo and
HashNuke
as code owners
|
Based on #2182, should be merged only after it or rebased |
kosstennbl
force-pushed
the
#2181-rename-setup-tasks
branch
2 times, most recently
from
9739fb9 to
a41b684
Compare
svteb
force-pushed
the
#2181-rename-setup-tasks
branch
from
a41b684 to
ace6b29
Compare
collivier
reviewed
Dec 19, 2024
collivier
approved these changes
Dec 20, 2024
Refs: #2181 Rename cnf_setup, cnf_cleanup and cluster_api_setup, cluster_api_cleanup tasks to cnf_install, cnf_uninstall and cluster_api_install, cluster_api_uninstall. Change documentation, specs and code accordingly. Signed-off-by: Konstantin Yarovoy <[email protected]>
svteb
force-pushed
the
#2181-rename-setup-tasks
branch
from
ace6b29 to
5e02b43
Compare
martin-mat
approved these changes
Jan 7, 2025
|
@svteb @martin-mat this may raise some side effects. I see some jobs can't pass now both on my PR and on main. More to come |
Some more info on this? I don;t quite understand why. |
|
@svteb right now just by observation: all the same jobs fail after multiple tries vs main and the PR about PSS. I'm on it (it could be also the previous commit). |
svteb
added a commit
that referenced
this pull request
Jan 9, 2025
- GH actions tag discovery command requires that there is a space between colon and the left bracket. - This has gone unnoticed in the #2184 pull request. Signed-off-by: svteb <[email protected]>
4 tasks
svteb
added a commit
that referenced
this pull request
Jan 9, 2025
- GH actions tag discovery command requires that there is a space between colon and the left bracket, this wasn't discovered and the skip started occuring in #2184. - Additionally there was an undiscovered error due to this test being skipped, which is now resolved (a message that is to be checked was changed). Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 16, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
collivier
pushed a commit
that referenced
this pull request
Jan 16, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
martin-mat
pushed a commit
that referenced
this pull request
Jan 17, 2025
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
added a commit
that referenced
this pull request
Jan 17, 2025
- GH actions tag discovery command requires that there is a space between colon and the left bracket, this wasn't discovered and the skip started occuring in #2184. - Additionally there was an undiscovered error due to this test being skipped, which is now resolved (a message that is to be checked was changed). Signed-off-by: svteb <[email protected]>
martin-mat
pushed a commit
that referenced
this pull request
Jan 17, 2025
- GH actions tag discovery command requires that there is a space between colon and the left bracket, this wasn't discovered and the skip started occuring in #2184. - Additionally there was an undiscovered error due to this test being skipped, which is now resolved (a message that is to be checked was changed). Signed-off-by: svteb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename cnf_setup, cnf_cleanup and
setuptasks to cnf_install, cnf_uninstall,install_dependenciesChange documentation, specs and code accordingly
Issues:
Refs: #2181