Fix: Repair uninstall_all
#2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svteb this cannot be verified asis because of the bitnami helm charts (it would reach the docker pull limit). |
collivier
force-pushed
the
fix_uninstall_all
branch
from
6db5733 to
21ca63c
Compare
svteb
force-pushed
the
fix_uninstall_all
branch
3 times, most recently
from
662820f to
11f72f1
Compare
Refs: #2209 - The "uninstall_all" was broken during development of #2120, to fix the issue a failure when there is no CNF to uninstall has been relegated to a warning and exit 1 was removed. - Two spec tests have been added to avoid this scenario in the future. - Additionally some renaming was left-over from #2184 that was resolved. Signed-off-by: svteb <[email protected]>
svteb
force-pushed
the
fix_uninstall_all
branch
from
11f72f1 to
d7d704a
Compare
collivier
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of release v1.4.0 the
uninstall_alltask is broken and some testsuite dependencies cannot be uninstalled the intended way (cluster tools, etc.). This has been caused by theCNFInstall.uninstall_cnffunction that was exiting with code 1 in case no CNF was installed, to fix this we have decided to relegate it to a warning (this makes the change significantly easier) and removed theexit 1command.To avoid a similar situation in future, two spec tests have been added. The
uninstall_allspec test required a change totools_uninstalltask since it previously gave no indication of passing. Further verification oftools_uninstallpassing correctly should be added, but it might be out of the scope of this ticket.Additionally some renaming regarding cleanup/uninstall has been left undone after #2184, this has been remediated as part of this ticket.
Issues:
Refs: #2209
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue