Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update React Router mentions #1748

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: Update React Router mentions #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/components/control/signed-in.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ The `<SignedIn>` component offers authentication checks as a cross-cutting conce
Below is an example of how to use `<SignedIn>` with React Router. The `<SignedIn>` component can be used as a child of a `<Route />` component to render content only to signed in users.

```tsx {{ filename: 'app.tsx' }}
import { Routes, Route } from 'react-router-dom'
import { Routes, Route } from 'react-router'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to https://reactrouter.com/upgrading/v6#upgrade-to-v7

import { ClerkProvider, SignedIn } from '@clerk/clerk-react'

function App() {
Expand Down
2 changes: 1 addition & 1 deletion docs/components/control/signed-out.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The `<SignedOut>` component offers authentication checks as a cross-cutting conc
Below is an example of how to use `<SignedOut>` with React Router. The `<SignedOut>` component can be used as a child of a `<Route />` component to render content only to signed in users.

```tsx {{ filename: 'app.tsx' }}
import { Routes, Route } from 'react-router-dom'
import { Routes, Route } from 'react-router'
import { ClerkProvider, SignedOut, RedirectToSignIn } from '@clerk/clerk-react'

function App() {
Expand Down
2 changes: 1 addition & 1 deletion docs/references/react/add-react-router.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ description: Learn how to add React Router to your React application using their
</TutorialHero>

> [!WARNING]
> [Loaders](https://reactrouter.com/en/main/route/loader) and [Actions](https://reactrouter.com/en/main/route/action) are currently not supported by Clerk with React Router.
> This tutorial is written for [React Router 6](https://reactrouter.com/6.28.0/home) and doesn't support [loaders](https://reactrouter.com/6.28.0/route/loader) and [actions](https://reactrouter.com/6.28.0/route/action).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the new SDK is out I'll revisit this doc


Learn how to add React Router to your application using React Router's new Data API router. This tutorial will cover configuring layouts and setting up protected routes.

Expand Down