fix: Update React Router mentions #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, here’s your docs preview: https://clerk.com/docs/pr/1748 |
LekoArts
commented
Nov 27, 2024
| @@ -87,7 +87,7 @@ The `<SignedIn>` component offers authentication checks as a cross-cutting conce | |||
| Below is an example of how to use `<SignedIn>` with React Router. The `<SignedIn>` component can be used as a child of a `<Route />` component to render content only to signed in users. | |||
|
|
|||
| ```tsx {{ filename: 'app.tsx' }} | |||
| import { Routes, Route } from 'react-router-dom' | |||
| import { Routes, Route } from 'react-router' | |||
There was a problem hiding this comment.
This refers to https://reactrouter.com/upgrading/v6#upgrade-to-v7
LekoArts
commented
Nov 27, 2024
| @@ -32,7 +32,7 @@ description: Learn how to add React Router to your React application using their | |||
| </TutorialHero> | |||
|
|
|||
| > [!WARNING] | |||
| > [Loaders](https://reactrouter.com/en/main/route/loader) and [Actions](https://reactrouter.com/en/main/route/action) are currently not supported by Clerk with React Router. | |||
| > This tutorial is written for [React Router 6](https://reactrouter.com/6.28.0/home) and doesn't support [loaders](https://reactrouter.com/6.28.0/route/loader) and [actions](https://reactrouter.com/6.28.0/route/action). | |||
There was a problem hiding this comment.
Once the new SDK is out I'll revisit this doc
alexisintech
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
Checklist