[TST] Enable test_add in distributed tests #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
HammadB
commented
May 17, 2024
| @@ -42,6 +42,8 @@ | |||
| hypothesis.settings.load_profile(os.getenv("HYPOTHESIS_PROFILE", "dev")) | |||
|
|
|||
| NOT_CLUSTER_ONLY = os.getenv("CHROMA_CLUSTER_TEST_ONLY") != "1" | |||
| MEMBERLIST_SLEEP = 5 | |||
There was a problem hiding this comment.
move into conftest colocated with other relevant CONSTs
HammadB
commented
May 17, 2024
| import chromadb.test.property.strategies as strategies | ||
| import chromadb.test.property.invariants as invariants | ||
| from chromadb.utils.batch_utils import create_batches | ||
|
|
||
| collection_st = st.shared(strategies.collections(with_hnsw_params=True), key="coll") | ||
|
|
||
|
|
||
| def reset(api: ServerAPI) -> None: |
There was a problem hiding this comment.
eventually might make sense to pull this out into conftest. also shouldn't we be able to use before() type semantics in pytest?
1 task
HammadB
force-pushed
the
hammad/enable_test_add
branch
from
7d5243c
to
b559dd5
Compare
HammadB
force-pushed
the
hammad/enable_test_add
branch
from
b559dd5
to
ae94dc7
Compare
HammadB
force-pushed
the
hammad/get_all_metadata
branch
from
e2a9ea7
to
3782e63
Compare
HammadB
force-pushed
the
hammad/enable_test_add
branch
from
ae94dc7
to
cc15917
Compare
HammadB
force-pushed
the
hammad/enable_test_add
branch
from
cc15917
to
677b91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
This enables tests
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None