Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Make metadata reader() respect get_all() semantics #2222

Merged
merged 7 commits into from
May 20, 2024
Merged

[ENH] Make metadata reader() respect get_all() semantics #2222

merged 7 commits into from
May 20, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented May 17, 2024 •
edited

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fix the python logservice batch size to some arbitrary default. We should change this later to be more principled.
    • Switch storage in memory blockfile to be BTreeMap so it follows the sort order of Arrow.
  • New functionality
    • MetadataReader should respect the semantics expected by python which are get() with no ids or filter returns everything. Eventually we will guard this with limit offset.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 7:59pm

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented May 17, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

HammadB
HammadB commented May 17, 2024
View reviewed changes
rust/worker/Cargo.toml Outdated Show resolved Hide resolved
HammadB
HammadB commented May 17, 2024
View reviewed changes
rust/worker/src/blockstore/memory/storage.rs
@@ -976,39 +1056,39 @@ impl<'referred_data> Readable<'referred_data> for DataRecord<'referred_data> {

#[derive(Clone)]
pub(crate) struct StorageBuilder {
bool_storage: Arc<RwLock<Option<HashMap<CompositeKey, bool>>>>,
bool_storage: Arc<RwLock<Option<BTreeMap<CompositeKey, bool>>>>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swtich to Btree to respect sort order

@HammadB HammadB requested a review from sanketkedia May 17, 2024 17:09
This was referenced May 17, 2024
Merged
Merged
@HammadB HammadB merged commit 51c4b52 into main May 20, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishiihara Ishiihara Ishiihara approved these changes

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HammadB @Ishiihara