Fix Podaacpy issues in Intro_09_Xarray_advanced_hurricane_case_study.ipynb #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
His @ cgentemann this issue addresses #7
Please look at the additional parameters I've added to the respective function calls.
There is a big somewhere in the granule_search in that the
start_timetemporal parameter is not being correctly interpreted and all granules from the beginning of the dataset until theend_timebeing retrieved. This is a bug and I will address it and write a unit test for this exact scenario. The workaround for the time being is to sort the granules by descending order meaning that you get theend_timefirst. In your example you only use one daily granule so this is OK.