Display different eva links depending on semester

[joaquintomas2003]

What

• Si corresponde, mostrar mas de un link de EVA, uno por cada semestre.

Pending questions

• Hay mas cursos con mas de un EVA?
• Podríamos guardar los eva_ids de otra forma?

[EmilioCristalli]

thoughts about adding a separate field/column for this?

[joaquintomas2003]

you mean adding an extra column for the eva_id of the second semester?
I think it would look cleaner for sure, but in 99% of cases it would be null, are we ok with that?

[EmilioCristalli]

you mean adding an extra column for the eva_id of the second semester?
yeah

IMO it's ok if it's almost always null, but open to discuss it if others prefer reusing the same field

[joaquintomas2003]

wdyt about it now?
I like it more than having it in the same field, but I'm still not convinced, the naming of the column seems kind of odd, but maybe that's me 🤣

[EmilioCristalli]

Suggested change

	def up
	add_column :subjects, :second_semester_eva_id, :string, if_not_exists: true
	end
	def down
	remove_column :subjects, :second_semester_eva_id, if_exists: true
	end
	def change
	add_column :subjects, :second_semester_eva_id, :string
	end

[EmilioCristalli]

Suggested change

	<%= display_eva_links(@subject) %>
	<% second_semester_eva_id = @subject.second_semester_eva_id %>
	<%= render 'shared/eva_links_component', eva_id: @subject.eva_id, text: second_semester_eva_id ? "EVA - Primer semestre" : "EVA" %>
	<%= render 'shared/eva_links_component', eva_id: second_semester_eva_id, text: "EVA - Segundo semestre" if second_semester_eva_id %>

if you like it better, i think you can do something like this to make it more direct and avoid the helper and method on the model.

I'm ok either way