Skip to content

Commit

Permalink
move multiple_eva_links? method to model
Browse files Browse the repository at this point in the history
  • Loading branch information
joaquintomas2003 committed Feb 1, 2025
1 parent affbe2d commit a9d5fee
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
8 changes: 1 addition & 7 deletions app/helpers/subjects_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def display_activity_prerequisite(activity_prerequisite)
end

def display_eva_links(subject)
if multiple_eva_links?(subject)
if subject.multiple_eva_links?
first_semester = render 'shared/eva_links_component', eva_id: subject.eva_id,
text: "EVA - Primer semestre"
second_semester = render 'shared/eva_links_component', eva_id: subject.second_semester_eva_id,
Expand All @@ -47,10 +47,4 @@ def display_eva_links(subject)
render 'shared/eva_links_component', eva_id: subject.eva_id, text: "EVA"
end
end

private

def multiple_eva_links?(subject)
subject.second_semester_eva_id.present?
end
end
4 changes: 4 additions & 0 deletions app/models/subject.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,9 @@ def average_rating
reviews.average(:rating).round(1) if reviews.any?
end

def multiple_eva_links?
second_semester_eva_id.present?
end

delegate :available?, to: :course
end

0 comments on commit a9d5fee

Please sign in to comment.