New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borrow rate types and parsers #22205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgermain
force-pushed
the
isolated-borrow-rate
branch
from
April 19, 2024 23:26
a5c99e6
to
d8b2d03
Compare
@carlosmiei It looks like the type import isn't being transpiled, do you know why this isn't happening?
|
|
|
kroitor
pushed a commit
that referenced
this pull request
Apr 28, 2024
* chore: new type IsolatedBorrowRate * refactor: changed BorrowRate type to CrossBorrowRate * feat(base/exchange): parseIsolatedBorrowRates, parseIsolatedBorrowRate * feat: new types - CrossBorrowRate, IsolatedBorrowRate * fetchCrossBorrowRate(s) return type * fetch(Cross|Isolated)BorrowRate(s) return types * base/Exchange import CrossBorrowRate * Exchange.ts removed BorrowRate type * types.py linting * fix crossborrowRates transpiling * bybit minor fix --------- Co-authored-by: carlosmiei <[email protected]> [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsolatedBorrowRate
,IsolatedBorrowRates
,CrossBorrowRates
BorrowRate
type renamed toCrossBorrowRate
(it's so far unused, so this shouldn't create problems)parseIsolatedBorrowRates
andparseIsolatedBorrowRate
fetchCrossBorrowRate
andfetchCrossBorrowRates
Testing