Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binance): fetchIsolatedBorrowRates #22206

Merged

Conversation

samgermain
Copy link
Member

@samgermain samgermain commented Apr 19, 2024

% py binance fetchIsolatedBorrowRate BTC/USDT
Python v3.9.6
CCXT v4.3.11
binance.fetchIsolatedBorrowRate(BTC/USDT)
{'base': 'BTC',
 'baseRate': 3.424e-05,
 'datetime': None,
 'info': {'data': [{'borrowLimit': '72',
                    'coin': 'BTC',
                    'dailyInterest': '0.00003424'},
                   {'borrowLimit': '900000',
                    'coin': 'USDT',
                    'dailyInterest': '0.00026096'}],
          'leverage': '10',
          'symbol': 'BTCUSDT',
          'vipLevel': '0'},
 'period': 86400000,
 'quote': 'USDT',
 'quoteRate': 0.00026096,
 'symbol': 'BTC/USDT',
 'timestamp': None}

@samgermain samgermain marked this pull request as draft April 24, 2024 00:03
@samgermain samgermain closed this Apr 29, 2024
@samgermain samgermain reopened this Apr 29, 2024
@samgermain samgermain marked this pull request as ready for review May 2, 2024 05:37
@carlosmiei carlosmiei self-assigned this May 2, 2024
@carlosmiei
Copy link
Collaborator

@samgermain next time, please don't forget the tests (I will add them this time)

@carlosmiei carlosmiei merged commit 16051c4 into ccxt:master May 2, 2024
1 of 2 checks passed
kroitor pushed a commit that referenced this pull request May 2, 2024
* chore: new type IsolatedBorrowRate

* refactor: changed BorrowRate type to CrossBorrowRate

* feat(base/exchange): parseIsolatedBorrowRates, parseIsolatedBorrowRate

* feat: new types - CrossBorrowRate, IsolatedBorrowRate

* fetchCrossBorrowRate(s) return type

* feat(binance): fetchIsolatedBorrowRates

* fetch(Cross|Isolated)BorrowRate(s) return types

* base/Exchange import CrossBorrowRate

* Exchange.ts removed BorrowRate type

* types.py linting

* fix crossborrowRates transpiling

* binance.fetchIsolatedBorrowRate update method signature and return type

* binance.parseIsolatedBorrowRate minor fix

* add static tests

---------

Co-authored-by: carlosmiei <[email protected]>

[ci skip]
@samgermain
Copy link
Member Author

@samgermain next time, please don't forget the tests (I will add them this time)

please don't add them if I forget again, let me fix my own mistakes please

@samgermain samgermain deleted the binance-fetch-isolated-borrow-rates branch May 2, 2024 20:53
DelAnt pushed a commit to DelAnt/ccxt that referenced this pull request May 10, 2024
* chore: new type IsolatedBorrowRate

* refactor: changed BorrowRate type to CrossBorrowRate

* feat(base/exchange): parseIsolatedBorrowRates, parseIsolatedBorrowRate

* feat: new types - CrossBorrowRate, IsolatedBorrowRate

* fetchCrossBorrowRate(s) return type

* feat(binance): fetchIsolatedBorrowRates

* fetch(Cross|Isolated)BorrowRate(s) return types

* base/Exchange import CrossBorrowRate

* Exchange.ts removed BorrowRate type

* types.py linting

* fix crossborrowRates transpiling

* binance.fetchIsolatedBorrowRate update method signature and return type

* binance.parseIsolatedBorrowRate minor fix

* add static tests

---------

Co-authored-by: carlosmiei <[email protected]>
DelAnt pushed a commit to DelAnt/ccxt that referenced this pull request May 10, 2024
* chore: new type IsolatedBorrowRate

* refactor: changed BorrowRate type to CrossBorrowRate

* feat(base/exchange): parseIsolatedBorrowRates, parseIsolatedBorrowRate

* feat: new types - CrossBorrowRate, IsolatedBorrowRate

* fetchCrossBorrowRate(s) return type

* feat(binance): fetchIsolatedBorrowRates

* fetch(Cross|Isolated)BorrowRate(s) return types

* base/Exchange import CrossBorrowRate

* Exchange.ts removed BorrowRate type

* types.py linting

* fix crossborrowRates transpiling

* binance.fetchIsolatedBorrowRate update method signature and return type

* binance.parseIsolatedBorrowRate minor fix

* add static tests

---------

Co-authored-by: carlosmiei <[email protected]>

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants