-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageInterface
#1190
base: main
Are you sure you want to change the base?
Add ImageInterface
#1190
Conversation
metadata = super().get_metadata() | ||
|
||
# Add basic metadata about the images | ||
metadata["Images"] = dict(description="Images loaded through ImageInterface", num_images=len(self.file_paths)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would you need to indicate the number of images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't as far as I see. I uncritically accepted this from cline I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, I also added the correct headers on the rst
that you mentioned.
docs/user_guide/image.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ben mentioned that a better place for this might be the conversion gallery and I think he is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
+ Coverage 89.65% 89.73% +0.08%
==========================================
Files 129 131 +2
Lines 8378 8536 +158
==========================================
+ Hits 7511 7660 +149
- Misses 867 876 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Should close #1186.