Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageInterface #1190

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add ImageInterface #1190

wants to merge 13 commits into from

Conversation

h-mayorquin
Copy link
Collaborator

Should close #1186.

@h-mayorquin h-mayorquin marked this pull request as ready for review February 10, 2025 21:39
metadata = super().get_metadata()

# Add basic metadata about the images
metadata["Images"] = dict(description="Images loaded through ImageInterface", num_images=len(self.file_paths))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you need to indicate the number of images?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't as far as I see. I uncritically accepted this from cline I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, I also added the correct headers on the rst that you mentioned.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben mentioned that a better place for this might be the conversion gallery and I think he is right.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 90.51724% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (89aac67) to head (d087e15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/neuroconv/datainterfaces/image/imageinterface.py 90.26% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
+ Coverage   89.65%   89.73%   +0.08%     
==========================================
  Files         129      131       +2     
  Lines        8378     8536     +158     
==========================================
+ Hits         7511     7660     +149     
- Misses        867      876       +9     
Flag Coverage Δ
unittests 89.73% <90.51%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/datainterfaces/__init__.py 100.00% <100.00%> (ø)
src/neuroconv/datainterfaces/image/__init__.py 100.00% <100.00%> (ø)
...c/neuroconv/datainterfaces/image/imageinterface.py 90.26% <90.26%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ImageInterface
2 participants