Do not convert non-neural channels to ElectricalSeries on OpenEphysBinaryRecordingInterface
#1179
Conversation
| @@ -108,6 +108,13 @@ def __init__( | |||
| if stub_test: | |||
| self.subset_channels = [0, 1] | |||
|
|
|||
| # Check if the recording has ADC channels | |||
There was a problem hiding this comment.
In the data from Kind Lab, they have AUX (AUX1, AUX2, AUX3), not ADC, for the accelerometer signals.
Should we go the other way around? --> checking that the channel_id contains CH, and only if it contains CH we add that as ElectricalSeries.
There was a problem hiding this comment.
That's a great suggestion. Let me debug against that data. Could you talk to them to see if we can see use some of their data in our gin tests? I can then stub some of that .
There was a problem hiding this comment.
Ah, but I just checked and your data is legacy, right? This PR is for the binary format where the channels are only ADC:
https://open-ephys.github.io/gui-docs/User-Manual/Recording-data/Open-Ephys-format.html
https://open-ephys.github.io/gui-docs/User-Manual/Recording-data/Binary-format.html
Your data might need another PR altogether.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 89.72% 89.73%
=======================================
Files 129 129
Lines 8420 8425 +5
=======================================
+ Hits 7555 7560 +5
Misses 865 865
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Should close #1023
Part of an effort like the one in:
#1152
Will add another PR at some point to transform the non-neural channels to a TimeSeries automatically.