Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send $login event fo filter #7
base: main
Are you sure you want to change the base?
Send $login event fo filter #7
Changes from all commits
0afd5d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of rescuing the error, should we default the failover in the gem? This would allow implementer of the gem to catch and handle the error themselves.
https://github.com/castle/castle-ruby/blob/108e9174af109d18d667979a9fa7b16017b779c9/lib/castle/api/filter.rb#L21-L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! My concern is that the SDK doesn't really handle all the errors. WDYT we should do in case we get one of
Castle::APIErrors
that are not handled? https://github.com/castle/castle-ruby/blob/108e9174af109d18d667979a9fa7b16017b779c9/lib/castle/errors.rb#L29There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the implementer decide! At least that's what makes the most sense to me at least. And that seems more like a bug in the underlying logic of
castle-ruby
but that's my interpretation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bartes could you chime in here as well? Why do we handle only some errors in the Ruby SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What errors does the SDK do not cover ? I think it covers those which are related to performing the request to the api (at least it should) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case where the Exception doesn't get caught is
InvalidParams
. I'm not sure that I'd want to swallow that error though because in that case the implementer would never really know their request was invalid. I'm not sure about other cases.