Send $login event fo filter #7
Conversation
| else | ||
| # everything fine, continue | ||
| end | ||
| rescue Castle::Error => e |
There was a problem hiding this comment.
Instead of rescuing the error, should we default the failover in the gem? This would allow implementer of the gem to catch and handle the error themselves.
There was a problem hiding this comment.
That makes sense! My concern is that the SDK doesn't really handle all the errors. WDYT we should do in case we get one ofCastle::APIErrors that are not handled? https://github.com/castle/castle-ruby/blob/108e9174af109d18d667979a9fa7b16017b779c9/lib/castle/errors.rb#L29
There was a problem hiding this comment.
Let the implementer decide! At least that's what makes the most sense to me at least. And that seems more like a bug in the underlying logic of castle-ruby but that's my interpretation.
There was a problem hiding this comment.
Hey @bartes could you chime in here as well? Why do we handle only some errors in the Ruby SDK?
There was a problem hiding this comment.
What errors does the SDK do not cover ? I think it covers those which are related to performing the request to the api (at least it should) ?
There was a problem hiding this comment.
One case where the Exception doesn't get caught is InvalidParams. I'm not sure that I'd want to swallow that error though because in that case the implementer would never really know their request was invalid. I'm not sure about other cases.
No description provided.