Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit validation result output to a certain size and print the number of remaining errors #19600

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: limit validation result output to a certain size and print the number of remaining errors #19600

wants to merge 4 commits into from

Commits on Jun 20, 2024

  1. fix: limit validation result output to a certain size and print the n… 

    …umber of remaining errors

- updating camunda-bpm-platform version to 7.22.0-SNAPSHOT since it has our new api allowing a size limit
- using 2kb as max size since it is half of the default nginx ingress proxy header size
- extended the formatter to implement methods to format a suffix with the number of non-printed results
- aggregating the design-time and the run-time results, to set the limit once and print the correct remaining items
    @mustafadagher
    mustafadagher committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bdecec5 View commit details
    Browse the repository at this point in the history

  2. feat: make validator results output MaxSize configurable

    @mustafadagher
    mustafadagher committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1913f18 View commit details
    Browse the repository at this point in the history

  3. test: verify validators results maxSize is being read correctly from … 

    …configs
    @mustafadagher
    mustafadagher committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    535093c View commit details
    Browse the repository at this point in the history

  4. docs: add validators.resultsOutputMaxSize config to broker.yaml con… 

    …fig templates
    @mustafadagher
    mustafadagher committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0c932d8 View commit details
    Browse the repository at this point in the history