Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit validation result output to a certain size and print the number of remaining errors #19600

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mustafadagher
Copy link
Contributor

@mustafadagher mustafadagher commented Jun 20, 2024

Description

Limit validation result output to a certain size and print the number of remaining errors

  • updating camunda-bpm-platform version to 7.22.0-SNAPSHOT since it has our new api allowing a size limit
  • extended the formatter to implement methods to format a suffix with the number of non-printed results
  • aggregating the design-time and the run-time results, so it's easier to set the limit once for all and print the correct remaining items
  • made max size configurable to allow different values for different cluster configs

Related issues

closes #19595
related to #11284
related to camunda/camunda-bpm-platform#4443

@mustafadagher mustafadagher self-assigned this Jun 20, 2024
@github-actions github-actions bot added component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Operate Integration Tests Results

0 tests   - 535   0 ✅  - 533   0s ⏱️ - 8m 35s
0 suites  -  89   0 💤  -   2 
0 files    -  89   0 ❌ ±  0 

Results for commit 0c932d8. ± Comparison against base commit a22744b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Operate Opensearch ITs Results

0 tests   - 182   0 ✅  - 182   0s ⏱️ - 1m 4s
0 suites  -  19   0 💤 ±  0 
0 files    -  19   0 ❌ ±  0 

Results for commit 0c932d8. ± Comparison against base commit a22744b.

♻️ This comment has been updated with latest results.

…umber of remaining errors

- updating camunda-bpm-platform version to 7.22.0-SNAPSHOT since it has our new api allowing a size limit
- using 2kb as max size since it is half of the default nginx ingress proxy header size
- extended the formatter to implement methods to format a suffix with the number of non-printed results
- aggregating the design-time and the run-time results, to set the limit once and print the correct remaining items
@mustafadagher mustafadagher force-pushed the 19595-update-zeebe-to-use-the-newer-version-of-camunda-bpm-platform-supporting-writing-with-a-maxsize-limit branch from c7d2774 to 0c932d8 Compare June 20, 2024 16:13
Copy link
Contributor

Tasklist Test Results

0 tests   - 564   0 ✅  - 559   0s ⏱️ - 1h 37m 48s
0 suites  - 146   0 💤  -   5 
0 files    - 146   0 ❌ ±  0 

Results for commit 0c932d8. ± Comparison against base commit a22744b.

1 similar comment
Copy link
Contributor

Tasklist Test Results

0 tests   - 564   0 ✅  - 559   0s ⏱️ - 1h 37m 48s
0 suites  - 146   0 💤  -   5 
0 files    - 146   0 ❌ ±  0 

Results for commit 0c932d8. ± Comparison against base commit a22744b.

Copy link
Contributor

Operate Unit Tests Results

0 tests   - 308   0 ✅  - 307   0s ⏱️ - 6m 53s
0 suites  -  51   0 💤  -   1 
0 files    -  51   0 ❌ ±  0 

Results for commit 0c932d8. ± Comparison against base commit a22744b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team component/zeebe Related to the Zeebe component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update zeebe to use the newer version of camunda-bpm-platform supporting writing with a maxSize limit
1 participant