-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add security notice 14 #5149
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @markfarkas-camunda! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the notice! Additionally to the individual remarks, this has to be backported to all previous doc versions.
@camunda/tech-writers in this PR we cannot link the docker images for specific versions (which contains the fix) because Web Modeler does not distribute images prior to 8.6 publicly, only on registry.camunda.cloud. In this case what should be the desired format of this security notice? |
My understanding based on the Slack thread is this will go out next week with the official release. Would it be ready then? If so, we can just keep this in a PR and you can add the link when it's ready. |
@akeller If you are referring to the docker images, those won't be available, Web Modeler just simply does not offer public Docker images, so we cannot link to previous versions, and we won't be able to in the future either. The question is: can we just skip the linking in this case? (mentioning the versions with the fix but only as plain text and not as links)
That is my understanding as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments - looks good now!
Description
We had a critical vulnerability in Web Modeler. Jira ticket: https://jira.camunda.com/browse/SEC-1285
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.