Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(reference): add security notice 15 #5150

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

buccarel
Copy link
Contributor

@buccarel buccarel commented Mar 5, 2025

Description

When should this change go live?

March 11, 2025

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@buccarel buccarel requested a review from a team March 5, 2025 17:10
@buccarel buccarel self-assigned this Mar 5, 2025

#### Impact

The version of Camunda Optimize was affected by a vulnerability that allows a malicious attacker to craft Camunda URLs that could execute Javascript code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[all.glossary] Inconsistent spelling detected. Use JavaScript instead of Javascript. Review the WCoE glossary - https://confluence.camunda.com/x/b5RZBw .

@akeller
Copy link
Member

akeller commented Mar 5, 2025

@buccarel can you please include more context for this security notice? Usually these require immediate review/merge/publish, so I'm surprised to see you've aligned it to an alpha/minor.

@akeller akeller added the component:optimize Issues related with Optimize project label Mar 5, 2025
Comment on lines 11 to 15
### Notice 14

#### Publication date

March 11th, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these both be listed under the same security notice? #5149

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are separate things in separate components. I assume we should have different security notices for these?

RomanJRW
RomanJRW previously approved these changes Mar 5, 2025
Copy link
Contributor

@RomanJRW RomanJRW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally no issue, but we need to use the right number and the Javascript spelling issue looks legit

Comment on lines 11 to 15
### Notice 14

#### Publication date

March 11th, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are separate things in separate components. I assume we should have different security notices for these?

@buccarel buccarel force-pushed the sec-notice-open-redirect branch from 5336011 to 6a65be3 Compare March 6, 2025 11:36
@buccarel buccarel changed the title docs(reference): add security notice 14 docs(reference): add security notice 15 Mar 6, 2025
@buccarel
Copy link
Contributor Author

buccarel commented Mar 6, 2025

@buccarel can you please include more context for this security notice? Usually these require immediate review/merge/publish, so I'm surprised to see you've aligned it to an alpha/minor.

@akeller this issue was reported to us right before we did the 8.6.6 release. We could squeeze it in that same release just in time, and we took advantage of the release being already scheduled.

With different circumstances, we would have done an emergency, out-of-schedule rollout

@buccarel buccarel requested review from RomanJRW and akeller March 6, 2025 12:21
RomanJRW
RomanJRW previously approved these changes Mar 6, 2025
@mesellings mesellings self-requested a review March 7, 2025 16:24
mesellings
mesellings previously approved these changes Mar 7, 2025
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some rewording suggestions, but I'm not clear about exactly what the past/present tense usage should be here as I don't know enough about this issue to tell quickly. Please use this suggestion as guidance. However, I think the rewording around "The version of Camunda" does need to be applied at least, as I'm not sure currently what's there makes sense?

Cautiously approving to unblock if there is urgency, but I suggest @akeller takes a look as well if there is time?

@buccarel buccarel dismissed stale reviews from mesellings and RomanJRW via a68d5a2 March 7, 2025 17:40
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - approved from a writing/grammar point of view! 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:optimize Issues related with Optimize project
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

4 participants