Skip to content

fastcgi: check for CONTENT_LENGTH when sending requests #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mholt merged 4 commits into from
Dec 18, 2024
Merged

fastcgi: check for CONTENT_LENGTH when sending requests #6661

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78265c6
fastcgi: check for CONTENT_LENGTH when sending requests
WeidiDeng Oct 24, 2024
6db43b6
order imports
WeidiDeng Oct 24, 2024
f0801b9
use strconv.ParseUint instead of strconv.ParseInt
WeidiDeng Dec 18, 2024
a55962a
Merge branch 'master' into fastcgi-cl-header
mholt Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/caddyhttp/reverseproxy/fastcgi/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ import (

"go.uber.org/zap"
"go.uber.org/zap/zapcore"

"github.com/caddyserver/caddy/v2/modules/caddyhttp"
)

// FCGIListenSockFileno describes listen socket file number.
Expand Down Expand Up @@ -136,6 +138,18 @@ type client struct {
// Do made the request and returns a io.Reader that translates the data read
// from fcgi responder out of fcgi packet before returning it.
func (c *client) Do(p map[string]string, req io.Reader) (r io.Reader, err error) {
// check for CONTENT_LENGTH, since the lack of it or wrong value will cause the backend to hang
if clStr, ok := p["CONTENT_LENGTH"]; !ok {
return nil, caddyhttp.Error(http.StatusLengthRequired, nil)
} else {
cl, err := strconv.ParseInt(clStr, 10, 64)
// stdlib won't return a negative Content-Length, but we check just in case,
// the most likely cause is from a missing content length, which is -1
if err != nil || cl < 0 {
return nil, caddyhttp.Error(http.StatusLengthRequired, err)
}
}
Comment thread
WeidiDeng marked this conversation as resolved.
Outdated

writer := &streamWriter{c: c}
writer.buf = bufPool.Get().(*bytes.Buffer)
writer.buf.Reset()
Expand Down