fastcgi: check for CONTENT_LENGTH when sending requests

[WeidiDeng]

For #6637, I think previous pr is a bit too ambitious. Requests buffering is hard to do right without considering a multitude of factors. This patch only requires CONTENT_LENGTH to be set for fastcgi requests.

[francislavoie]

So we just throw 411 for any chunked requests? Makes sense that it'll prevent hanging. But long term, shouldn't we have support for streaming chunked requests?

[WeidiDeng]

php-fpm doesn't support streaming chunked requests. That's the thing. Golang fastcgi supports streaming chunked requests, but does anyone use that with caddy?

[francislavoie]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57087 looks like Apache fixed their fpm support with buffering

[lutoma]

Are there any updates on this (or the other patch for the issue)? Seeing these PRs just lying around for a month is pretty discouraging when this is essentially a DoS that seems to affect a lot of people

[mohammed90]

Are there any updates on this (or the other patch for the issue)? Seeing these PRs just lying around for a month is pretty discouraging when this is essentially a DoS that seems to affect a lot of people

The patch only been up for 3 weeks, and it's under review. We've been releasing 2.9.0 betas. You can build Caddy with this patch using xcaddy.

[mholt]

Thanks Weidi. I like the more conservative approach. Maybe in the future we can figure out how to fix it with buffering to disk, but for now, this will do. :) Really appreciate it!