-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerise #16
Dockerise #16
Conversation
@forus is the intention here to eventually have a separate docker image just for importing? |
@inodb but those actions in the TODO should happen now, but later after some deprecation time. Does it make sense? |
@ruslan-forostianov that makes sense. I created separate follow-up items for this: cBioPortal/cbioportal#10734. Updated the description of the PR |
Move scripts out of java jar Fix tests diff by removing absolut path It seems like currently report has been generated inside from container. But the test should work when run from any dev machine Add Dockerfile Include scripts into jar for backward compatibility Remove redundant gitignore for the jar file Use maven:3-eclipse-temurin-2 as jar build image instead Skip tests while building jar file for Dockerfile Install python on java docker image instead of otherwise python is more straightforward to install than java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except the python gh action
It seems like jinja2 started to remove newline character since recent version?
@haynescd thanks for catching it. I've pushed the fix. Please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes:
Moved scripts from the jar artifact to the project's root directory, improving the development experience by making the environment more familiar and convenient for script developers.
Imported the
requirements.txt
file for installing Python dependencies from the cBioPortal project, ensuring consistency and ease of setup for Python-related tasks.Developed a new Docker image that is fully equipped with all necessary dependencies, offering a ready-to-use environment for running the Java loader or executing scripts.
Follow up items in: cBioPortal/cbioportal#10734