Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a separate container for importing #10734

Open
3 tasks
inodb opened this issue Apr 4, 2024 · 0 comments
Open
3 tasks

Use a separate container for importing #10734

inodb opened this issue Apr 4, 2024 · 0 comments

Comments

@inodb
Copy link
Member

inodb commented Apr 4, 2024

We currently use a single container for both data importing. Let's split this up in web and data importing. There is a PR that set up the container for cbioportal-core: cBioPortal/cbioportal-core#16.

A few things are remaining.

Need to discuss:

  • Remove inclusion of cbioportal-core in the final cbioportal Docker image during the Docker build process cBioPortal/cbioportal@master/docker/web-and-data/Dockerfile#L48. Or maybe remove that version of Dockerfile as a whole?
  • The cbioportal-core name doesn't quite seem to cover what this repo does. Should it be called cbioportal-importer? Or cbioportal-data-import? Or something like that?

TODO:

  • Update tests to use this new importer image
  • Update cbioportal-docker-compose to use the new importer docker image
  • Update documentation pages with how to use importer docker image directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant