-
Notifications
You must be signed in to change notification settings - Fork 66
Migrate from sbt to bazel #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 97 commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
78af2a6
Migrate from sbt to bazel
agluszak ddeaece
Fix
agluszak e41b5d7
Fix documentation generation (#616)
KatKlo c326796
Revert java formatting
agluszak 76b4ae9
Fixes
agluszak 9c7c5f9
Fixes
agluszak 6c0e2fb
Fix formatting
agluszak 9fec740
Fix formatting
agluszak aa5a6da
Fix workspace
agluszak 2b1a352
Fix
agluszak 096e02b
Update to docusaurus 3
agluszak 99535f3
Merge branch 'master' into agluszak/docusaurus-3
agluszak f50f2f7
Fix workspace
agluszak 7707a1e
Bump
agluszak ce721c0
update according to bsp-generators (#628)
KatKlo 2d3bd48
Merge remote-tracking branch 'origin/master' into agluszak/bazel
agluszak 34233a6
WIP
agluszak 1805a01
WIP
agluszak 299b1c2
WIP
agluszak 3b42487
Merge branch 'master' into agluszak/bazel
agluszak 19600e8
Big update: migrate to bazel 7 & bzlmod, use new formatting rules
agluszak 2b096b4
Merge remote-tracking branch 'origin/agluszak/docusaurus-3' into aglu…
agluszak 587dea3
Fix
agluszak a987562
Fix
agluszak acd6b7f
WIP
agluszak c7e9f84
WIP
agluszak d6be090
WIP
agluszak c4688ff
WIP
agluszak 2a567c7
WIP
agluszak 4f03763
WIP
agluszak 2060c1b
WIP
agluszak 0b6be5d
WIP
agluszak dbb6a02
WIP
agluszak 4c9bc60
WIP
agluszak d886a7f
WIP
agluszak 7e7a602
WIP
agluszak b5026ef
WIP
agluszak 903ebc9
WIP
agluszak 5365deb
WIP
agluszak 7b7517e
WIP
agluszak d81bf0c
WIP
agluszak 397e1d0
WIP
agluszak 96d468c
WIP
agluszak d2e0a5f
WIP
agluszak a32a858
WIP
agluszak c7139bf
WIP
agluszak 391445b
WIP
agluszak 7bfcf67
WIP
agluszak 2543a0e
WIP
agluszak 1e33921
WIP
agluszak d7cbfe8
WIP
agluszak facc8a0
WIP
agluszak 882af81
WIP
agluszak c4e3216
WIP
agluszak 6bfb056
WIP
agluszak dcda1e4
WIP
agluszak a73b157
WIP
agluszak ad4fba2
WIP
agluszak d972ddf
WIP
agluszak 9c929a3
WIP
agluszak cd4e370
WIP
agluszak d72ed83
WIP
agluszak 4edf259
WIP
agluszak 0153a1b
WIP
agluszak e9d3b0b
WIP
agluszak 29c5e27
WIP
agluszak cd9e004
WIP
agluszak 8a8a8c0
WIP
agluszak d772aaa
WIP
agluszak df8fd51
WIP
agluszak f5f4740
WIP
agluszak c91c203
WIP
agluszak 070aebe
WIP
agluszak 27c1951
fix
agluszak 650c7a1
Fix
agluszak c7d3a2c
Fix
agluszak b3d3da9
WIP
agluszak 1eebd92
WIP
agluszak 34780cf
WIP
agluszak 955efd1
WIP
agluszak de90a95
WIP
agluszak 1d490ca
WIP
agluszak 97753d3
WIP
agluszak 5c5e0f7
WIP
agluszak 604a157
WIP
agluszak 10fa033
WIP
agluszak 00a5a87
Handle missing newline in private key
agluszak 2f1631d
WIP
agluszak 2b194fa
WIP
agluszak 984ffb3
WIP
agluszak 83ce535
WIP
agluszak 6f933f2
WIP
agluszak 7584e39
WIP
agluszak 0ed03cc
Fix
agluszak 381e22a
Fix
agluszak 8b03a2d
Fix
agluszak fdf839d
Fix
agluszak d369cb2
Fix
agluszak b3846de
Fix
agluszak f19789b
Fix
agluszak d24d711
Fix
agluszak d11effa
Fix
agluszak 63961de
Fix
agluszak 45323e7
Empty-Commit
agluszak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
website/node_modules | ||
bazel-out | ||
bazel-bin | ||
bazel-testlogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,152 @@ | ||
# https://docs.aspect.build/guides/bazelrc/ | ||
|
||
common --java_language_version=17 | ||
common --tool_java_language_version=17 | ||
common --java_runtime_version=remotejdk_17 | ||
common --tool_java_runtime_version=remotejdk_17 | ||
|
||
# Do not upload locally executed action results to the remote cache. | ||
# This should be the default for local builds so local builds cannot poison the remote cache. | ||
# It should be flipped to `--remote_upload_local_results` on CI | ||
# by using `--bazelrc=.aspect/bazelrc/ci.bazelrc`. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--remote_upload_local_results | ||
build --noremote_upload_local_results | ||
|
||
# Don't allow network access for build actions in the sandbox. | ||
# Ensures that you don't accidentally make non-hermetic actions/tests which depend on remote | ||
# services. | ||
# Developers should tag targets with `tags=["requires-network"]` to opt-out of the enforcement. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--sandbox_default_allow_network | ||
build --sandbox_default_allow_network=false | ||
|
||
# Warn if a test's timeout is significantly longer than the test's actual execution time. | ||
# Bazel's default for test_timeout is medium (5 min), but most tests should instead be short (1 min). | ||
# While a test's timeout should be set such that it is not flaky, a test that has a highly | ||
# over-generous timeout can hide real problems that crop up unexpectedly. | ||
# For instance, a test that normally executes in a minute or two should not have a timeout of | ||
# ETERNAL or LONG as these are much, much too generous. | ||
# Docs: https://bazel.build/docs/user-manual#test-verbose-timeout-warnings | ||
test --test_verbose_timeout_warnings | ||
|
||
# Allow the Bazel server to check directory sources for changes. Ensures that the Bazel server | ||
# notices when a directory changes, if you have a directory listed in the srcs of some target. | ||
# Recommended when using | ||
# [copy_directory](https://github.com/aspect-build/bazel-lib/blob/main/docs/copy_directory.md) and | ||
# [rules_js](https://github.com/aspect-build/rules_js) since npm package are source directories | ||
# inputs to copy_directory actions. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--host_jvm_args | ||
startup --host_jvm_args=-DBAZEL_TRACK_SOURCE_DIRECTORIES=1 | ||
|
||
# Allow exclusive tests to run in the sandbox. Fixes a bug where Bazel doesn't enable sandboxing for | ||
# tests with `tags=["exclusive"]`. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_exclusive_test_sandboxed | ||
test --incompatible_exclusive_test_sandboxed | ||
|
||
# Use a static value for `PATH` and does not inherit `LD_LIBRARY_PATH`. Doesn't let environment | ||
# variables like `PATH` sneak into the build, which can cause massive cache misses when they change. | ||
# Use `--action_env=ENV_VARIABLE` if you want to inherit specific environment variables from the | ||
# client, but note that doing so can prevent cross-user caching if a shared cache is used. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_strict_action_env | ||
build --incompatible_strict_action_env | ||
|
||
# Propagate tags from a target declaration to the actions' execution requirements. | ||
# Ensures that tags applied in your BUILD file, like `tags=["no-remote"]` | ||
# get propagated to actions created by the rule. | ||
# Without this option, you rely on rules authors to manually check the tags you passed | ||
# and apply relevant ones to the actions they create. | ||
# See https://github.com/bazelbuild/bazel/issues/8830 for details. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_allow_tags_propagation | ||
build --experimental_allow_tags_propagation | ||
fetch --experimental_allow_tags_propagation | ||
query --experimental_allow_tags_propagation | ||
|
||
# Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong | ||
# default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python | ||
# package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the | ||
# default), it is treated as false if and only if this flag is set. See | ||
# https://github.com/bazelbuild/bazel/issues/10076. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_default_to_explicit_init_py | ||
build --incompatible_default_to_explicit_init_py | ||
|
||
# Set default value of `allow_empty` to `False` in `glob()`. This prevents a common mistake when | ||
# attempting to use `glob()` to match files in a subdirectory that is opaque to the current package | ||
# because it contains a BUILD file. See https://github.com/bazelbuild/bazel/issues/8195. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_disallow_empty_glob | ||
common --incompatible_disallow_empty_glob | ||
|
||
# Always download coverage files for tests from the remote cache. By default, coverage files are not | ||
# downloaded on test result cahce hits when --remote_download_minimal is enabled, making it impossible | ||
# to generate a full coverage report. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_fetch_all_coverage_outputs | ||
# detching remote cache results | ||
test --experimental_fetch_all_coverage_outputs | ||
|
||
# Attempt to build & test every target whose prerequisites were successfully built. | ||
# Docs: https://bazel.build/docs/user-manual#keep-going | ||
build --keep_going | ||
|
||
# Output test errors to stderr so users don't have to `cat` or open test failure log files when test | ||
# fail. This makes the log noiser in exchange for reducing the time-to-feedback on test failures for | ||
# users. | ||
# Docs: https://bazel.build/docs/user-manual#test-output | ||
test --test_output=errors | ||
|
||
# Show the output files created by builds that requested more than one target. This helps users | ||
# locate the build outputs in more cases | ||
# Docs: https://bazel.build/docs/user-manual#show-result | ||
build --show_result=20 | ||
|
||
# Bazel picks up host-OS-specific config lines from bazelrc files. For example, if the host OS is | ||
# Linux and you run bazel build, Bazel picks up lines starting with build:linux. Supported OS | ||
# identifiers are `linux`, `macos`, `windows`, `freebsd`, and `openbsd`. Enabling this flag is | ||
# equivalent to using `--config=linux` on Linux, `--config=windows` on Windows, etc. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--enable_platform_specific_config | ||
common --enable_platform_specific_config | ||
|
||
# Output a heap dump if an OOM is thrown during a Bazel invocation | ||
# (including OOMs due to `--experimental_oom_more_eagerly_threshold`). | ||
# The dump will be written to `<output_base>/<invocation_id>.heapdump.hprof`. | ||
# You may need to configure CI to capture this artifact and upload for later use. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--heap_dump_on_oom | ||
common --heap_dump_on_oom | ||
|
||
# Don't apply `--noremote_upload_local_results` and `--noremote_accept_cached` to the disk cache. | ||
# If you have both `--noremote_upload_local_results` and `--disk_cache`, then this fixes a bug where | ||
# Bazel doesn't write to the local disk cache as it treats as a remote cache. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_remote_results_ignore_disk | ||
build --incompatible_remote_results_ignore_disk | ||
|
||
# Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. | ||
# Save time on Sandbox creation and deletion when many of the same kind of action run during the | ||
# build. | ||
# No longer experimental in Bazel 6: https://github.com/bazelbuild/bazel/commit/c1a95501a5611878e5cc43a3cc531f2b9e47835b | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories | ||
build --experimental_reuse_sandbox_directories | ||
|
||
# Speed up all builds by not checking if external repository files have been modified. | ||
# Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java#L244 | ||
build --noexperimental_check_external_repository_files | ||
fetch --noexperimental_check_external_repository_files | ||
query --noexperimental_check_external_repository_files | ||
|
||
# Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. | ||
# Save time on Sandbox creation and deletion when many of the same kind of action run during the | ||
# build. | ||
# Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories | ||
build --reuse_sandbox_directories | ||
|
||
# Avoid this flag being enabled by remote_download_minimal or remote_download_toplevel | ||
# See https://meroton.com/blog/bazel-6-errors-build-without-the-bytes/ | ||
build --noexperimental_action_cache_store_output_metadata | ||
|
||
# Speed up all builds by not checking if output files have been modified. Lets you make changes to | ||
# the output tree without triggering a build for local debugging. For example, you can modify | ||
# [rules_js](https://github.com/aspect-build/rules_js) 3rd party npm packages in the output tree | ||
# when local debugging. | ||
# Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/pkgcache/PackageOptions.java#L185 | ||
# NB: This flag is in bazel6.bazelrc as when used in Bazel 7 is has been observed to break | ||
# "build without the bytes" --remote_download_outputs=toplevel. See https://github.com/aspect-build/bazel-lib/pull/711 | ||
# for more info. | ||
build --noexperimental_check_output_files | ||
fetch --noexperimental_check_output_files | ||
query --noexperimental_check_output_files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
7.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
website/generated/**/* linguist-generated=true | ||
bsp4j/src/**/* linguist-generated=true | ||
bsp4s/src/**/* linguist-generated=true | ||
website/generated/**/* linguist-generated=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,17 +11,54 @@ jobs: | |
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- uses: actions/setup-java@v4 | ||
- name: Mount bazel cache | ||
uses: actions/cache@v4 | ||
with: | ||
distribution: "temurin" | ||
java-version: "11" | ||
cache: "sbt" | ||
- name: Publish ${{ github.ref }} | ||
run: sbt ci-release docs/docusaurusPublishGhpages | ||
env: | ||
GIT_DEPLOY_KEY: ${{ secrets.GIT_DEPLOY_KEY }} | ||
GIT_USER: [email protected] | ||
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | ||
PGP_SECRET: ${{ secrets.PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | ||
path: '/home/runner/.cache/bazel' | ||
key: bazel | ||
save-always: true | ||
- uses: crazy-max/ghaction-import-gpg@v6 | ||
with: | ||
gpg_private_key: ${{ secrets.PGP_SECRET }} | ||
passphrase: ${{ secrets.PGP_PASSPHRASE }} | ||
- name: Generate docs | ||
run: bazel run //website:docusaurus-build | ||
- name: Upload Build Artifact | ||
uses: actions/upload-pages-artifact@v3 | ||
with: | ||
path: bazel-out/k8-fastbuild/bin/website/docusaurus-build.sh.runfiles/_main/website/build | ||
- name: Publish bsp4j artifacts | ||
run: | | ||
bazel run \ | ||
--define "maven_repo=https://oss.sonatype.org/service/local" \ | ||
--define "maven_user=$MAVEN_USER" \ | ||
--define "maven_password=$MAVEN_PASSWORD" \ | ||
//bsp4j:bsp4j.publish | ||
- name: Publish bsp4s artifacts | ||
run: | | ||
bazel run \ | ||
--define "maven_repo=https://oss.sonatype.org/service/local" \ | ||
--define "maven_user=$MAVEN_USER" \ | ||
--define "maven_password=$MAVEN_PASSWORD" \ | ||
//bsp4s:bsp4s.publish | ||
deploy: | ||
name: Deploy to GitHub Pages | ||
needs: publish | ||
# Grant GITHUB_TOKEN the permissions required to make a Pages deployment | ||
permissions: | ||
pages: write # to deploy to Pages | ||
id-token: write # to verify the deployment originates from an appropriate source | ||
# Deploy to the github-pages environment | ||
environment: | ||
name: github-pages | ||
url: ${{ steps.deployment.outputs.page_url }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Deploy to GitHub Pages | ||
id: deployment | ||
uses: actions/deploy-pages@v4 | ||
env: | ||
GIT_DEPLOY_KEY: ${{ secrets.GIT_DEPLOY_KEY }} | ||
GIT_USER: [email protected] | ||
MAVEN_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
MAVEN_USER: ${{ secrets.SONATYPE_USERNAME }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,80 +14,31 @@ jobs: | |
fetch-depth: 0 | ||
- uses: actions/setup-java@v4 | ||
with: | ||
distribution: "temurin" | ||
java-version: "11" | ||
cache: "sbt" | ||
|
||
- name: generate | ||
run: sbt generate | ||
|
||
distribution: 'temurin' | ||
java-version: '17' | ||
- name: Mount bazel cache | ||
uses: actions/cache@v4 | ||
with: | ||
path: '/home/runner/.cache/bazel' | ||
key: bazel | ||
- name: Generate | ||
# Generate libraries and the website | ||
run: bazel run //:generate | ||
- name: Build | ||
run: bazel build //... | ||
- name: Test | ||
run: bazel test //... | ||
- name: Verify Changed files | ||
uses: tj-actions/verify-changed-files@v17 | ||
uses: tj-actions/verify-changed-files@v19 | ||
id: verify-changed-files | ||
with: | ||
files: | | ||
**/*.java | ||
**/*.scala | ||
**/*.md | ||
|
||
bsp4s/src | ||
bsp4j/src | ||
website/generated | ||
- name: Fail if we detect changed files | ||
if: steps.verify-changed-files.outputs.files_changed == 'true' | ||
run: | | ||
echo "Detected changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" | ||
echo "Make sure to run 'sbt generate' before pushing." | ||
echo "Make sure to run 'bazel run //:generate' before pushing." | ||
exit 1 | ||
|
||
test: | ||
agluszak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: Run tests | ||
needs: check-generation | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-java@v4 | ||
with: | ||
distribution: "temurin" | ||
java-version: "11" | ||
cache: "sbt" | ||
|
||
- name: compile | ||
run: sbt +compile +package | ||
|
||
- name: test | ||
run: sbt +test | ||
|
||
docs: | ||
name: Generate docs site | ||
agluszak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-java@v4 | ||
with: | ||
distribution: "temurin" | ||
java-version: "11" | ||
cache: "sbt" | ||
- run: sbt docs/docusaurusCreateSite | ||
|
||
code-format-check: | ||
name: Check Scala formatting | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-java@v4 | ||
with: | ||
distribution: "temurin" | ||
java-version: "11" | ||
cache: "sbt" | ||
- run: sbt checkScalaFormat | ||
|
||
website-format-check: | ||
name: Check website formatting | ||
agluszak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Prettify code | ||
uses: creyD/[email protected] | ||
with: | ||
dry: true | ||
prettier_options: --ignore-path website/.prettierignore --check . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
.bsp/ | ||
bazel-* |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we be able to avoid checking in generated files in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they can be automatically generated, they should, unless there are good reasons not to (e.g. the tooling needs some remote resources temporarily unavailable or unstable).